Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standalone vector transform stage #2566

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

westonpace
Copy link
Contributor

This makes the vector transform stage a standalone operation.

@github-actions github-actions bot added enhancement New feature or request python labels Jul 5, 2024
@westonpace
Copy link
Contributor Author

Leaving in draft as this is dependent on #2556 and #2562 which are still awaiting review

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 5.40541% with 35 lines in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (b3ad008) to head (0939ebf).
Report is 7 commits behind head on main.

Files Patch % Lines
rust/lance/src/index/vector/ivf/builder.rs 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2566      +/-   ##
==========================================
- Coverage   80.00%   79.94%   -0.06%     
==========================================
  Files         209      209              
  Lines       59847    59949     +102     
  Branches    59847    59949     +102     
==========================================
+ Hits        47880    47928      +48     
- Misses       9143     9186      +43     
- Partials     2824     2835      +11     
Flag Coverage Δ
unittests 79.94% <5.40%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants