Repository navigation
fix: admit tested Hermes dependency versions - #12
Open
ethernet8023 wants to merge 1 commit into
Open
ethernet8023 wants to merge 1 commit into
ethernet8023 wants to merge 1 commit into
Conversation
15 of 17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change
lower the dependency minimums to the versions Hermes actually ships, with upper bounds:
openai>=2.24.0,<3requests>=2.33.0,<3botocore>=1.42.97,<2this completes the approach in #11, which lowers OpenAI/Requests but leaves
botocore>=1.43.16. that remaining floor conflicts with Hermes's boto3 requirement. credit to @teknium1 for #11.verification
adds Python 3.14/minimum-version CI coverage using
uv run --no-syncso tests retain the selected versions. Requests 2.33.0 keeps the documented security fix. no hosted API or downloaded reranker was exercised.Infographic