-
Notifications
You must be signed in to change notification settings - Fork 648
feat: support aggregate in scanner #5911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e7282e6
feat(lance): add Substrait aggregate support
jackye1995 8da6281
refactor(lance): rename AggregateSpec to AggregateExpr and consolidat…
jackye1995 74d0aac
chore: remove section separator comments from aggregate tests
jackye1995 81a0841
test(lance): add test for aggregate with filter
jackye1995 fa65725
refactor: move Aggregate struct to non-feature-gated module
jackye1995 f720e99
feat: add sorts support for aggregate functions
jackye1995 c64a1b6
test(lance): add tests for ordered aggregates with sorts
jackye1995 f9c5a15
address comments
jackye1995 576cdc0
address more comments
jackye1995 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // SPDX-FileCopyrightText: Copyright The Lance Authors | ||
|
|
||
| //! Aggregate specification for DataFusion aggregates. | ||
|
|
||
| use datafusion::logical_expr::Expr; | ||
|
|
||
| /// Aggregate specification with group by and aggregate expressions. | ||
| #[derive(Debug, Clone)] | ||
| pub struct Aggregate { | ||
| /// Expressions to group by (e.g., column references). | ||
| pub group_by: Vec<Expr>, | ||
| /// Aggregate function expressions (e.g., SUM, COUNT, AVG). | ||
| /// Use `.alias()` on the expression to set output column names. | ||
| pub aggregates: Vec<Expr>, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead and comment these two.