Skip to content

fix: fix deletion when using file-object-store:// #5760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonpace merged 8 commits into from
Jan 21, 2026
Merged

fix: fix deletion when using file-object-store:// #5760

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
be21726
fix: fix deletion when using file-object-store://
cmccabe Jan 20, 2026
869c077
re-add another create_dir_all line
cmccabe Jan 21, 2026
8f709d5
Merge branch 'main' into colin_fix_file_object_store
cmccabe Jan 21, 2026
cad1274
another tweak
cmccabe Jan 21, 2026
917c57d
add provider to comment
cmccabe Jan 21, 2026
28cac76
check for windows
cmccabe Jan 21, 2026
403abed
fix unit test
cmccabe Jan 21, 2026
4d8f5eb
clippy
cmccabe Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions rust/lance-io/src/object_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ impl ObjectStore {
let path = dir_path.into();
let path = Path::parse(&path)?;

if self.is_local() {
if self.is_local() || self.scheme == "file-object-store" {
// Local file system needs to delete directories as well.
return super::local::remove_dir_all(&path);
}
Expand Down Expand Up @@ -1099,11 +1099,19 @@ mod tests {
}

#[tokio::test]
async fn test_delete_directory() {
async fn test_delete_directory_local_store() {
test_delete_directory("").await;
}

#[tokio::test]
async fn test_delete_directory_file_object_store() {
test_delete_directory("file-object-store://").await;
}

async fn test_delete_directory(prefix: &str) {
let path = TempStdDir::default();
create_dir_all(path.join("foo").join("bar")).unwrap();
create_dir_all(path.join("foo").join("zoo")).unwrap();
create_dir_all(path.join("foo").join("zoo").join("abc")).unwrap();
Comment thread
cmccabe marked this conversation as resolved.
write_to_file(
path.join("foo")
.join("bar")
Expand All @@ -1113,8 +1121,8 @@ mod tests {
"delete",
)
.unwrap();
write_to_file(path.join("foo").join("top").to_str().unwrap(), "delete_top").unwrap();
let (store, base) = ObjectStore::from_uri(path.to_str().unwrap()).await.unwrap();
let uri = format!("{}{}", prefix, path.to_str().unwrap());
let (store, base) = ObjectStore::from_uri(&uri).await.unwrap();
store.remove_dir_all(base.child("foo")).await.unwrap();

assert!(!path.join("foo").exists());
Expand Down
Loading