Skip to content

docs: in dataset.rs, fix comment for get_fragments#5724

Merged
westonpace merged 1 commit intolance-format:mainfrom
cmccabe:colin_fix_comment
Jan 15, 2026
Merged

docs: in dataset.rs, fix comment for get_fragments#5724
westonpace merged 1 commit intolance-format:mainfrom
cmccabe:colin_fix_comment

Conversation

@cmccabe
Copy link
Copy Markdown
Contributor

@cmccabe cmccabe commented Jan 15, 2026

In rust/lance/src/dataset.rs, a comment for Dataset.get_fragments talks about a 'filter' parameter that doesn't actually exist. Remove this comment.

In rust/lance/src/dataset.rs, a comment for Dataset.get_fragments
talks about a 'filter' parameter that doesn't actually exist. Remove
this comment.
@github-actions github-actions Bot added the bug Something isn't working label Jan 15, 2026
@wjones127 wjones127 changed the title fix: in dataset.rs, fix comment for get_fragments docs: in dataset.rs, fix comment for get_fragments Jan 15, 2026
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jan 15, 2026
@westonpace westonpace merged commit 7d8d8c5 into lance-format:main Jan 15, 2026
28 of 31 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
In rust/lance/src/dataset.rs, a comment for Dataset.get_fragments talks
about a 'filter' parameter that doesn't actually exist. Remove this
comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants