docs: in dataset.rs, fix comment for get_fragments#5724
Merged
westonpace merged 1 commit intolance-format:mainfrom Jan 15, 2026
Merged
docs: in dataset.rs, fix comment for get_fragments#5724westonpace merged 1 commit intolance-format:mainfrom
westonpace merged 1 commit intolance-format:mainfrom
Conversation
In rust/lance/src/dataset.rs, a comment for Dataset.get_fragments talks about a 'filter' parameter that doesn't actually exist. Remove this comment.
wjones127
approved these changes
Jan 15, 2026
westonpace
approved these changes
Jan 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
In rust/lance/src/dataset.rs, a comment for Dataset.get_fragments talks about a 'filter' parameter that doesn't actually exist. Remove this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rust/lance/src/dataset.rs, a comment for Dataset.get_fragments talks about a 'filter' parameter that doesn't actually exist. Remove this comment.