Skip to content

perf: offload IVF partition build to CPU pool #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BubbleCal merged 2 commits into from
Dec 19, 2025
Merged

perf: offload IVF partition build to CPU pool #5551

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34c81a5
Offload IVF partition build
BubbleCal Dec 19, 2025
a16d9d0
Merge branch 'main' into offload-partition-build
Xuanwo Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 36 additions & 31 deletions rust/lance/src/index/vector/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,42 +780,47 @@ impl<S: IvfSubIndex + 'static, Q: Quantization + 'static> IvfIndexBuilder<S, Q>
.await?
};

if let Some((assign_batch, deleted_row_ids)) = assign_batch {
if !deleted_row_ids.is_empty() {
let deleted_row_ids = HashSet::<u64>::from_iter(
deleted_row_ids.values().iter().copied(),
);
for batch in batches.iter_mut() {
let row_ids = batch[ROW_ID].as_primitive::<UInt64Type>();
let mask =
BooleanArray::from_iter(row_ids.iter().map(|row_id| {
row_id.map(|row_id| !deleted_row_ids.contains(&row_id))
}));
*batch = arrow::compute::filter_record_batch(batch, &mask)?;
spawn_cpu(move || {
if let Some((assign_batch, deleted_row_ids)) = assign_batch {
if !deleted_row_ids.is_empty() {
let deleted_row_ids = HashSet::<u64>::from_iter(
deleted_row_ids.values().iter().copied(),
);
for batch in batches.iter_mut() {
let row_ids = batch[ROW_ID].as_primitive::<UInt64Type>();
let mask =
BooleanArray::from_iter(row_ids.iter().map(|row_id| {
row_id.map(|row_id| {
!deleted_row_ids.contains(&row_id)
})
}));
*batch = arrow::compute::filter_record_batch(batch, &mask)?;
}
}
}

if assign_batch.num_rows() > 0 {
// Drop PART_ID column from assign_batch to match schema of existing batches
let assign_batch = assign_batch.drop_column(PART_ID_COLUMN)?;
batches.push(assign_batch);
if assign_batch.num_rows() > 0 {
// Drop PART_ID column from assign_batch to match schema of existing batches
let assign_batch = assign_batch.drop_column(PART_ID_COLUMN)?;
batches.push(assign_batch);
}
}
}

let num_rows = batches.iter().map(|b| b.num_rows()).sum::<usize>();
if num_rows == 0 {
return Ok(None);
}
let num_rows = batches.iter().map(|b| b.num_rows()).sum::<usize>();
if num_rows == 0 {
return Ok(None);
}

let (storage, sub_index) = Self::build_index(
distance_type,
quantizer,
sub_index_params,
batches,
column,
frag_reuse_index,
)?;
Ok(Some((storage, sub_index, loss)))
let (storage, sub_index) = Self::build_index(
distance_type,
quantizer,
sub_index_params,
batches,
column,
frag_reuse_index,
)?;
Ok(Some((storage, sub_index, loss)))
})
.await
}
});
Ok(stream::iter(build_iter)
Expand Down