-
Notifications
You must be signed in to change notification settings - Fork 729
feat: add additional index APIs to support count rows split plan #5447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -834,6 +834,31 @@ public long countRows(String filter) { | |
|
|
||
| private native long nativeCountRows(Optional<String> filter); | ||
|
|
||
| /** | ||
| * Count rows matching a filter using a specific scalar index. This directly queries the index and | ||
| * counts matching row addresses, which is more efficient than scanning when the index covers the | ||
| * filter column. | ||
| * | ||
| * @param indexName the name of the scalar index to use | ||
| * @param filter the filter expression (e.g., "column = 5") | ||
| * @param fragmentIds optional list of fragment IDs to restrict the count to | ||
| * @return count of matching rows | ||
| */ | ||
| public long countIndexedRows( | ||
| String indexName, String filter, Optional<List<Integer>> fragmentIds) { | ||
| try (LockManager.ReadLock readLock = lockManager.acquireReadLock()) { | ||
| Preconditions.checkArgument(nativeDatasetHandle != 0, "Dataset is closed"); | ||
| Preconditions.checkArgument( | ||
| indexName != null && !indexName.isEmpty(), "indexName cannot be null or empty"); | ||
| Preconditions.checkArgument( | ||
| filter != null && !filter.isEmpty(), "filter cannot be null or empty"); | ||
| return nativeCountIndexedRows(indexName, filter, fragmentIds); | ||
| } | ||
| } | ||
|
|
||
| private native long nativeCountIndexedRows( | ||
| String indexName, String filter, Optional<List<Integer>> fragmentIds); | ||
|
|
||
| /** | ||
| * Calculate the size of the dataset. | ||
| * | ||
|
|
@@ -928,6 +953,20 @@ public List<String> listIndexes() { | |
|
|
||
| private native List<String> nativeListIndexes(); | ||
|
|
||
| /** | ||
| * Get all indexes with full metadata. | ||
| * | ||
| * @return list of Index objects with complete metadata including index type and fragment coverage | ||
| */ | ||
| public List<org.lance.index.Index> getIndexes() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we could use the short name and import it |
||
| try (LockManager.ReadLock readLock = lockManager.acquireReadLock()) { | ||
| Preconditions.checkArgument(nativeDatasetHandle != 0, "Dataset is closed"); | ||
| return nativeGetIndexes(); | ||
| } | ||
| } | ||
|
|
||
| private native List<org.lance.index.Index> nativeGetIndexes(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above |
||
|
|
||
| /** | ||
| * Get the table config of the dataset. | ||
| * | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is duplicated with https://github.com/majin1102/lance/blob/772c6d87a5b1d9530b5f3772fba7c33cf5c55b3a/java/lance-jni/src/transaction.rs#L81-L170
Maybe we should move that code here and add this index_type