Skip to content

chore: respect num_indices_to_merge param #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BubbleCal merged 2 commits into from
Nov 17, 2025
Merged

chore: respect num_indices_to_merge param #5253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
075c29a
chore: respect num_indices_to_merge param
BubbleCal Nov 17, 2025
fd3d8f1
fmt
BubbleCal Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions rust/lance/src/index/vector/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,9 +711,13 @@ impl<S: IvfSubIndex + 'static, Q: Quantization + 'static> IvfIndexBuilder<S, Q>
// if no partitions to split, we just create a new delta index,
// otherwise, we need to merge all existing indices and split large partitions.
let reader = reader.clone();
let num_indices_to_merge = self
.optimize_options
.as_ref()
.and_then(|opt| opt.num_indices_to_merge);
let (assign_batches, merge_indices, replaced_partition) =
match Self::should_split(ivf, reader.as_ref(), &self.existing_indices)? {
Some(partition) => {
Some(partition) if num_indices_to_merge.is_none() => {
// Perform split and record the fact for downstream build/merge
log::info!(
"split partition {}, will merge all {} delta indices",
Expand All @@ -734,19 +738,15 @@ impl<S: IvfSubIndex + 'static, Q: Quantization + 'static> IvfIndexBuilder<S, Q>
Some(partition),
)
}
None => {
_ => {
let is_retrain = self
.optimize_options
.as_ref()
.map(|opt| opt.retrain)
.unwrap_or(false);
let num_to_merge = match is_retrain {
true => self.existing_indices.len(), // retrain, merge all indices
false => self
.optimize_options
.as_ref()
.and_then(|opt| opt.num_indices_to_merge)
.unwrap_or(0),
false => num_indices_to_merge.unwrap_or(0),
};

let indices_to_merge = self.existing_indices
Expand Down