Skip to content

fix: remove remainder explain_plan method in Python #5085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonpace merged 2 commits into from
Oct 29, 2025
Merged

fix: remove remainder explain_plan method in Python #5085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33d3069
fix: add missing explain_plan pymethod in SqlQuery
ddupg Oct 28, 2025
f671992
fix: remove remainder explain_plan method in Python
ddupg Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions python/python/lance/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3466,7 +3466,7 @@ def sql(self, sql: str) -> "SqlQueryBuilder":
import lance
dataset = lance.dataset("/tmp/data.lance")
query = dataset.sql("SELECT id, name FROM dataset WHERE age > 30").build()
query.to_list()
query.to_batch_records()

"""
return SqlQueryBuilder(self._ds.sql(sql))
Expand Down Expand Up @@ -3575,24 +3575,6 @@ def to_stream_reader(self) -> pa.RecordBatchReader:
"""
return self._query.to_stream_reader()

def explain_plan(self, verbose: bool = False, analyze: bool = False) -> str:
"""
Explain the query plan.

Parameters
----------
verbose: bool, default False
If True, print the verbose plan.
analyze: bool, default False
If True, analyze the query and print the statistics.

Returns
-------
str
The query plan.
"""
return self._query.explain_plan(verbose, analyze)


class SqlQueryBuilder:
"""
Expand Down