Skip to content

chore: temporarily revert retries in merge insert #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wjones127 wants to merge 3 commits into from
Closed

chore: temporarily revert retries in merge insert #3799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00da1a6
temporarily revert retries in merge insert
wjones127 May 10, 2025
01e7f1f
clippy
wjones127 May 10, 2025
13a6b2d
cleanup
wjones127 May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,4 @@ redundant_clone = "deny"
print_stdout = "deny"
print_stderr = "deny"
# not too much we can do to avoid multiple crate versions
multiple-crate-versions = "allow"
multiple-crate-versions = "allow"
6 changes: 6 additions & 0 deletions rust/lance/src/dataset/write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,9 @@ async fn resolve_commit_handler(
/// data. Otherwise, the source will be spilled to a temporary file on disk.
///
/// This is used to support retries on write operations.
// TODO: we will use this again once we bring back
// https://github.com/lancedb/lance/issues/3798
#[allow(dead_code)]
async fn new_source_iter(
source: SendableRecordBatchStream,
enable_retries: bool,
Expand Down Expand Up @@ -685,6 +688,9 @@ async fn new_source_iter(
}
}

// We will use this again once we address this:
// https://github.com/lancedb/lance/issues/3798
#[allow(dead_code)]
struct SpillStreamIter {
receiver: SpillReceiver,
#[allow(dead_code)] // Exists to keep the SpillSender alive
Expand Down
Loading
Loading