fix: use shared arrow allocator and fix concurrent cortas#49
Merged
jackye1995 merged 4 commits intolance-format:mainfrom Feb 24, 2026
Merged
fix: use shared arrow allocator and fix concurrent cortas#49jackye1995 merged 4 commits intolance-format:mainfrom
jackye1995 merged 4 commits intolance-format:mainfrom
Conversation
jackye1995
changed the title
- Use shared allocator from LanceRuntime when opening datasets (Dataset.open(allocator, path, options) instead of Dataset.open(path, options)) This prevents datasets from closing their self-managed allocators while scanners are still using them. - Use child allocators in LanceBasePageSource for proper resource isolation Each page source creates a child allocator that's closed when done. - Don't close the root allocator in LanceRuntime.close() since concurrent operations may still be using it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
force-pushed
the
fix-concurrent-test
branch
from
f7959af to
aad6d88
Compare
Lance does not guarantee all concurrent inserts are visible due to its merge-on-read approach without proper distributed locking. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.