-
Notifications
You must be signed in to change notification settings - Fork 57
fix: align arrow version with spark and add docker integration tests #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8e9bc20
initial commit
hamersaw 26c73cc
added lightweight testing and fixed env vars in Makefile
hamersaw 929c40c
working e2e
hamersaw 3e89a1f
Merge remote-tracking branch 'upstream/main' into feature/docker-tests
hamersaw b76a0bf
keeping default Spark 3.5 and updating Spark 4.0 to Arrow 18.1
hamersaw 469933a
removing maven profiles and hardcoding versions in each module
hamersaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # syntax=docker/dockerfile:1 | ||
| # | ||
| # Minimal image for running lance-spark integration tests. | ||
| # Layers are ordered so that package installation is cached and only | ||
| # the Spark download + bundle JAR copy run on each rebuild. | ||
|
|
||
| FROM ubuntu:24.04 | ||
|
|
||
| # --- Cached layers: system packages and Python test deps --- | ||
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends \ | ||
| curl \ | ||
| openjdk-17-jdk-headless \ | ||
| python3 \ | ||
| python3-dev \ | ||
| python3-venv \ | ||
| python3-pip && \ | ||
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN python3 -m venv /opt/venv && \ | ||
| . /opt/venv/bin/activate && \ | ||
| pip install --upgrade pip && \ | ||
| pip install pytest pytest-timeout packaging | ||
|
|
||
| ENV PATH="/opt/venv/bin:$PATH" | ||
| ENV SPARK_HOME="/opt/spark" | ||
| ENV PYTHONPATH="${SPARK_HOME}/python:${PYTHONPATH}" | ||
| ENV PATH="${SPARK_HOME}/sbin:${SPARK_HOME}/bin:${PATH}" | ||
|
|
||
| ARG SPARK_DOWNLOAD_VERSION=4.0.0 | ||
| ARG SPARK_MAJOR_VERSION=4.0 | ||
| ARG SCALA_VERSION=2.13 | ||
| ARG PY4J_VERSION=0.10.9.9 | ||
|
|
||
| ENV PYTHONPATH="${SPARK_HOME}/python/lib/py4j-${PY4J_VERSION}-src.zip:${PYTHONPATH}" | ||
|
|
||
| RUN mkdir -p ${SPARK_HOME} \ | ||
| && curl https://archive.apache.org/dist/spark/spark-${SPARK_DOWNLOAD_VERSION}/spark-${SPARK_DOWNLOAD_VERSION}-bin-hadoop3.tgz \ | ||
| -o spark.tgz \ | ||
| && tar xzf spark.tgz --directory ${SPARK_HOME} --strip-components 1 \ | ||
| && rm spark.tgz | ||
|
|
||
| # --- Uncached layers: Spark download and bundle JAR --- | ||
|
|
||
| # Add a random query as a cache buster | ||
| ADD "https://www.random.org/cgi-bin/randbyte?nbytes=10&format=h" skipcache | ||
|
|
||
| COPY lance-spark-bundle-${SPARK_MAJOR_VERSION}_${SCALA_VERSION}-*.jar ${SPARK_HOME}/jars/ | ||
|
|
||
| # Spark configuration and entrypoint | ||
| COPY spark-defaults.conf ${SPARK_HOME}/conf/ | ||
| RUN chmod u+x ${SPARK_HOME}/sbin/* && \ | ||
| chmod u+x ${SPARK_HOME}/bin/* | ||
|
|
||
| # Create directories for Spark events and test data | ||
| RUN mkdir -p /home/lance/warehouse /home/lance/spark-events /home/lance/data | ||
|
|
||
| # Copy tests | ||
| RUN mkdir -p /home/lance/tests | ||
| COPY tests/ /home/lance/tests/ | ||
|
|
||
| WORKDIR ${SPARK_HOME} | ||
| COPY entrypoint.sh . | ||
|
|
||
| ENTRYPOINT ["./entrypoint.sh"] | ||
| CMD ["tail", "-f", "/dev/null"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| pytest==8.3.5 | ||
| pytest-timeout==2.3.1 | ||
| jupyterlab==3.6.7 | ||
| jupyter-server==1.24.0 | ||
| pandas==2.3.1 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.