Fix #19528: Actually remove Dynamic from interfaces of native JS classes.

[sjrd]

One boolean value was the wrong way around for native JS classes and traits. That caused scala.Dynamic not to be removed from the super-interfaces of native JS classes at the IR level, causing the linking error.

[OndrejSpanel]

I think this fix should be back-ported. The issue makes some Scala.js projects which worked in Scala 2 not buildable, with no good workaround.

The actual fix is change of a single boolean literal used for forJSClass parameter from false to true, therefore porting it should hopefully be trivial. The added tests are also straightforward, in a new file.

[OndrejSpanel]

Actually if I knew what branch should I target, I would gladly try preparing the backport PR.

[OndrejSpanel]

All other issues in Scala 3 I have reported have some workaround in my project, except this one - this issue is blocking me to move to Scala 3. It seems 3.4.1 release is just around a corner now, but that is Scala-next - going straight to it means manually disabling a bunch of new deprecation warnings.

When can Scala 3 LTS release with this fix (hopefully 3.3.4) be expected? Can I do something to expedite it?

The only info about upcoming LTS release I have found is https://users.scala-lang.org/t/scala-3-how-do-we-make-a-lambda-type-conform-to-a-subtype/9805/2:

The earliest the fix can be applied is 3.3.3 which is ~6 weeks from now.

This was Feb 16, 4 weeks ago.

I would really hate 3.3.4 to be released without this fix - and I am a bit worried about the silence on the LTS release front.

[sjrd]

You might help get it backported by submitting a PR with a cherry-pick to the release-3.3.4 branch.

I also added the backport:nominated label, just in case.

[OndrejSpanel]

I am a bit confused about Scala 3.3 LTS backports project - as I see it, the project is currently empty. Is the project used at all? I have added this PR into a column I think it belongs to, but I was quite surprised to see I am allowed to freely move the items around or even to edit workflows or to close the project if I want to. Am I supposed to have the access rights needed for this?

[OndrejSpanel]

And now there are no projects in https://github.com/orgs/scala/projects at all, open or closed. Confused even more. 😶

[OndrejSpanel]

There is now https://github.com/orgs/lampepfl/projects/6 in which this PR is in the column Needs Assessment

I would say it belongs to PR Submitted and could hopefully move to Backport Done soon, but there is little I can do to make it happen - I am not able to make any changes in that project which is how it should be.