Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Move settings.storage.cache_dir to settings.cache_dir #875

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Oct 1, 2024

Fix #620

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.61%. Comparing base (b35835b) to head (4787361).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lamindb_setup/core/_settings.py 82.14% 5 Missing ⚠️
lamindb_setup/core/_settings_save.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   83.38%   83.61%   +0.23%     
==========================================
  Files          43       43              
  Lines        3382     3381       -1     
==========================================
+ Hits         2820     2827       +7     
+ Misses        562      554       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 1, 2024

@Koncopd Koncopd changed the title ♻️ Move cache to lamindb_setup.settings ♻️ Move lamindb_setup.settings.storage.cache_dir to lamindb_setup.settings.cache_dir Oct 2, 2024
@Koncopd Koncopd changed the title ♻️ Move lamindb_setup.settings.storage.cache_dir to lamindb_setup.settings.cache_dir ♻️ Move settings.storage.cache_dir to settings.cache_dir Oct 2, 2024
@github-actions github-actions bot temporarily deployed to pull request October 2, 2024 08:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 2, 2024 09:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 2, 2024 09:52 Inactive
@Koncopd Koncopd merged commit 9df1486 into main Oct 2, 2024
13 checks passed
@Koncopd Koncopd deleted the cache_settings branch October 2, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lamin cache set doens't work if no instance is loaded
1 participant