Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix cache paths #874

Merged
merged 4 commits into from
Sep 30, 2024
Merged

🐛 Fix cache paths #874

merged 4 commits into from
Sep 30, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Sep 30, 2024

Fix #868

Copy link

github-actions bot commented Sep 30, 2024

@github-actions github-actions bot temporarily deployed to pull request September 30, 2024 09:30 Inactive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this just be?

cloud_file.touch(exist_ok=True)  

i.e. do you really want the file to be potentially truncated to 0 bytes?

see: fsspec/universal_pathlib#262

Copy link
Member Author

@Koncopd Koncopd Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one yes.
Without truncate it is not implemented error.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also do just unlink and touch ofc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is caught in universal-pathlib==0.2.5 though. Am I missing an edge case with the touch behaviour here?

https://github.com/fsspec/universal_pathlib/blob/5486fa3c30cbb3f79637252d980994a1d738b0f5/upath/core.py#L970-L980

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, yes, i mean in s3fs. But if i do via upath here it won't update the timestamp. This is the whole point of calling it here.

@github-actions github-actions bot temporarily deployed to pull request September 30, 2024 09:50 Inactive
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.32%. Comparing base (d4e6f38) to head (c3823c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   83.32%   83.32%           
=======================================
  Files          43       43           
  Lines        3382     3382           
=======================================
  Hits         2818     2818           
  Misses        564      564           
Flag Coverage Δ
83.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Koncopd Koncopd merged commit 5e6939d into main Sep 30, 2024
13 checks passed
@Koncopd Koncopd deleted the cache_apths branch September 30, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Fix permission error when saving a new artifact on python 3.12
2 participants