Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Speed up ln.connect() #871

Merged
merged 14 commits into from
Sep 29, 2024
Merged

⚡️ Speed up ln.connect() #871

merged 14 commits into from
Sep 29, 2024

Conversation

falexwolf
Copy link
Member

No description provided.

@falexwolf falexwolf changed the title ⚡️ Profile connect ⚡️ Profile ln.connect() Sep 29, 2024
@falexwolf
Copy link
Member Author

The first report was obtained with the code state up until here.

@falexwolf falexwolf changed the title ⚡️ Profile ln.connect() ⚡️ Speed up ln.connect() Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.29%. Comparing base (76b9907) to head (8c5b640).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lamindb_setup/_check_setup.py 90.90% 1 Missing ⚠️
lamindb_setup/_init_instance.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   83.59%   83.29%   -0.31%     
==========================================
  Files          43       43              
  Lines        3383     3382       -1     
==========================================
- Hits         2828     2817      -11     
- Misses        555      565      +10     
Flag Coverage Δ
83.29% <88.88%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request September 29, 2024 21:10 Inactive
@falexwolf falexwolf merged commit 2b58e1a into main Sep 29, 2024
10 checks passed
@falexwolf falexwolf deleted the profileconnect branch September 29, 2024 21:45
@github-actions github-actions bot temporarily deployed to pull request September 29, 2024 21:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant