🔧 Use LAMINDB_DJANGO_DATABASE_URL instead of DATABASE_URL

[Koncopd]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (db0d9a0) to head (5eb5c3d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
lamindb_setup/core/_settings_instance.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   83.45%   83.43%   -0.02%     
==========================================
  Files          43       43              
  Lines        3355     3357       +2     
==========================================
+ Hits         2800     2801       +1     
- Misses        555      556       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🚀 Deployed on https://66e2b9d6fef47d3f93ff90b6--lamindb-setup-htry.netlify.app

[falexwolf]

Shouldn't this be called LAMINDB_INSTANCE_DB, because that's what it's called in pydantic, which has the same behavior.

[falexwolf]

(It also let's a set env variable take supersede whatever is in the .env file.)

[Koncopd]

Uh, this is yet another env varibale here

lamindb-setup/lamindb_setup/_connect_instance.py

Line 73 in db0d9a0

db_dsn_local = LaminDsnModel(db=os.getenv("LAMINDB_INSTANCE_DB"))

i wasn't aware

[Koncopd]

Then need to rework this a bit.

[Koncopd]

Hm, i am not sure now that it is better to point to already existing LAMINDB_INSTANCE_DB. LAMINDB_INSTANCE_DB is actually a proper thing, that is validated. And this one (LAMINDB_DATABASE_URL) is just something that overwrites any connection whatever it is. They should not be conflated i believe. And also double overwrite will be confusing we use LAMINDB_INSTANCE_DB here.

@falexwolf maybe lets call it not LAMINDB_DATABASE_URL but something like LAMINDB_DJANGO_DATABASE_URL just to be sure that is not accidently used, because DATABASE_URL is really generic.

[falexwolf]

I like your last solution!

[Koncopd]

Ok, merging then.