Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Test connect_instance_new for anonymous #850

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Sep 10, 2024

And add fallback for db user.

Copy link

github-actions bot commented Sep 10, 2024

@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 13:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 15:21 Inactive
@Koncopd Koncopd changed the title ✨ Use connect_instance_new ✨ Test connect_instance_new for anonymous Sep 10, 2024
@Koncopd Koncopd changed the title ✨ Test connect_instance_new for anonymous ✅ Test connect_instance_new for anonymous Sep 10, 2024
@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 18:36 Inactive
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.47%. Comparing base (b3f1706) to head (810ea61).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lamindb_setup/core/_hub_core.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   83.56%   83.47%   -0.09%     
==========================================
  Files          43       43              
  Lines        3346     3352       +6     
==========================================
+ Hits         2796     2798       +2     
- Misses        550      554       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Koncopd Koncopd merged commit e104ca0 into main Sep 10, 2024
11 of 13 checks passed
@Koncopd Koncopd deleted the use_connect_instance_new branch September 10, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant