✨ Load instance settings with edge function

[Koncopd]

https://github.com/laminlabs/laminhub/pull/1209

[github-actions]

🚀 Deployed on https://66df1a05f4514f32a3783c78--lamindb-setup-htry.netlify.app

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (ce27649) to head (cbebc2c).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
lamindb_setup/core/_hub_core.py	84.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #848   +/-   ##
=======================================
  Coverage   83.55%   83.56%           
=======================================
  Files          43       43           
  Lines        3320     3346   +26     
=======================================
+ Hits         2774     2796   +22     
- Misses        546      550    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Koncopd]

@falexwolf i think this is ready, along this https://github.com/laminlabs/laminhub/pull/1209

[falexwolf]

We also need the schema_id, here, don't we?

For laminr (WP).

[Koncopd]

Added.

[falexwolf]

This looks great to me!

It'd be nice though if this was starting to go live for the lamin team so that we build confidence in it. We could check for whether a user handle is in sunnyosun, Koncopd, zethson, falexwolf and then call the new connect function instead of the old one. Can you make this change.

Note: For laminr, we'll need to document how to call this edge function from within R. But that's probably for Notion.

[falexwolf]

Can you call it _connect_instance_new() instead?

And then we'll delete the existing _connect_instance function once we spend 1-2 weeks testing it.

[Koncopd]

done

[falexwolf]

Thanks, Sergei! 3 small changes, please.

[Koncopd]

It'd be nice though if this was starting to go live for the lamin team so that we build confidence in it. We could check for whether a user handle is in sunnyosun, Koncopd, zethson, falexwolf and then call the new connect function instead of the old one. Can you make this change.

This i will add to ln.connect in a new PR when the edge function is deployed.

[falexwolf]

Ok! Agreed!