🐛 Fix analysis-flow registration #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
falexwolf
reviewed
Aug 30, 2024
| @@ -14,11 +14,13 @@ | |||
| var_index=bt.Gene.ensembl_gene_id, | |||
| categoricals={ | |||
| "cell_type": bt.CellType.name, | |||
| "cell_type_id": bt.CellType.ontology_id, | |||
There was a problem hiding this comment.
• 1 non-validated categories are not saved in Feature.name: ['cell_type_id']!
→ to lookup categories, use lookup().columns
→ to save, run add_new_from_columns
is what you get otherwise
There was a problem hiding this comment.
Ok 🤔
Is that a warning or does it prevent .validate() from succeeding? What if I'm not interested in validating that column? Often times, I'd like to keep a few "raw columns" around and only want to validate the "gold columns", right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.