Expose the internal middleware queue in MiddlewarePipe as an iterable
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns the internal `SplQueue` as an array so that users can inspect the pipeline. Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
v4/middleware-pipe-to-array
branch
from
a80f851
to
8f7a08c
Compare
Ocramius
reviewed
Jul 17, 2024
src/MiddlewarePipeInterface.php
Outdated
Comment on lines
14
to
15
| /** @return list<MiddlewareInterface> */ | ||
| public function toArray(): array; |
There was a problem hiding this comment.
I thought so too… If you need the convenience of inspecting the pipeline, like in tests, then it's not much to ask to first assert the implementation type.
There was a problem hiding this comment.
I've added a new interface with no additional methods that extends from MiddlewarePipeInterface and IteratorAggregate so that users can test for IterableMiddlewarePipeInterface and simply call iterator_to_array on the pipeline instance. Better?
…implementation. Signed-off-by: George Steel <[email protected]>
gsteel
changed the title
toArray to MiddlewarePipeInterfacetoArray to MiddlewarePipe
…g the pipeline itself iterable Signed-off-by: George Steel <[email protected]>
gsteel
changed the title
toArray to MiddlewarePipeMiddlewarePipe as an iterable
Ocramius
approved these changes
Jul 17, 2024
Comment on lines
10
to
11
| /** @extends IteratorAggregate<int, MiddlewareInterface> */ | ||
| interface IterableMiddlewarePipeInterface extends MiddlewarePipeInterface, IteratorAggregate |
There was a problem hiding this comment.
Since this is not internal, I would describe it: other than that, all good!
Signed-off-by: George Steel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Returns the internal
SplQueueas an array so that users can inspect the pipeline.Closes #44