Bump PSR-7 dependency to allow usage with v2 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the psr/http-message dependency to allow v2. Test changes are due to the fact that a number of mocks were not returning the correct value, and with RTH defined in v2, these were now raising errors. With the changes, they are now more correct, and test assertions continued to pass without issue. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Each of the test cases updated were asserting the type of an object returned from one of the shipped functions. However, each of these functions has return type declarations, making the assertions redundant. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
- Updated Psalm config to add configuration for upcoming version (findUnusedBaselineEntry, findUnusedCode) - We had three test asset classes that were no longer used. - A test was using deprecated PHPUnit functionality; rewrote in a way that will be forwards compatible. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
1 task
boesing
approved these changes
May 9, 2023
| }, | ||
| "require-dev": { | ||
| "laminas/laminas-coding-standard": "~2.5.0", | ||
| "laminas/laminas-diactoros": "^2.22", | ||
| "laminas/laminas-diactoros": "^2.25 || ^3.0", |
There was a problem hiding this comment.
I'd say lets drop support for http-message v1.0 and bump it to 1.1, then we can just require diactoros v3 and don't have to hassle with v2 here.
WDYT?
There was a problem hiding this comment.
My main reason to keep 1.0 support was because I'm not 100% certain which of our components depend explicitly on Diactoros, and this would allow usage with v2 or v3 of that library until those are updated.
I think in 3.11 we could drop 1.0 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch bumps the psr/http-message version to allow v2.0, and also bumps the testing requirements to allow either Diactoros 2 or 3 versions. Internally, since we are only consuming PSR-7, there are no code changes required. However, due to the fact that v2 has explicitly declared type hints, a number of locations in the tests where we were defining mocks needed updates to ensure that method parameters and return types used conformed to the specification.
Additionally, when running QA checks, I discovered (a) a test that was using deprecated PHPUnit functionality (fixed to be forwards compatible), and (b) 3 unused test asset classes (now removed).
Replaces #40