UTILS: Remove redundant check in Utils::getStatusCode()
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional test to demonstrate it behaving the same. Signed-off-by: Remy Bos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Remy Bos [email protected]
Description
This PR removes a redundant check in the conditional within the
Utils::getStatusCode()method.Within the body of
Utils::getStatusCode()a call is made to ResponseInterface::getStatusCode(). This method is documented to return an integer. The only scenario where! $statuswould evaluate to true is whenever a statuscode of0is returned. This case is also covered by the check$status < 400and could therefore be safely removed.A test case is added to demonstrate that the same resultant status code is obtained.
If there is anything I overlooked please let me know!