Remove marshalUriFromSapi function #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marked for removal for 3.0.0, so this patch removes it. It also removes tests in `ServerRequestFactoryTest` that exercised it, as these had been largely moved to the `UriFactoryTest` already. One test method was found that had not, and was moved to that factory. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
- adds a migration note - removes reference from API documentation Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
psalm config file also has issue handler for this |
Removes issue suppressions for marshalUriFromSapi and GdImage from Psalm config. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Resolved. |
Xerkus
approved these changes
May 2, 2023
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In version 2.11.0, we deprecated the
Laminas\Diactoros\marshalUriFromSapi()function, and moved its functionality toUriFactory::createFromSapi().This patch removes it for the v3.0.0 release, and documents the removal in the migration guide.
Fixes #149