-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage with PSR-7 v2 #136
Commits on Apr 18, 2023
-
fix: adapts code to work with v2 of PSR-7 interfaces
Many tests become redundant with proper types present. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 76c9d36 - Browse repository at this point
Copy the full SHA 76c9d36View commit details
Commits on May 1, 2023
-
refactor: use updated versions of PSR-17 interfaces and integration t…
…ests - Updates to version 1.0.2 of the PSR-17 interfaces, which allow usage with PSR-7 v2 - Updates to version 1.3.0 of the psr7-integration-tests, which allow usage with PSR-7 1.1 and 2.0. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b1ca975 - Browse repository at this point
Copy the full SHA b1ca975View commit details -
refactor: remove obsolete type checks where possible
Due to updating to use PSR-7 v2, we can remove a number of conditionals that did type-checking, and also update constructors to use union types to fully type the API exposed. Doing so removes the need for some unit tests, as type errors will now be guaranteed by the runtime. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1badd91 - Browse repository at this point
Copy the full SHA 1badd91View commit details -
qa: apply phpcs fixes, and ensure tests pass
- Updates the ref for the PSR-7 integration tests with a version known to work. - Fixes the signature of `CallbackStream::seek` to add the `void` return declaration. - Applies CS rules. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e84d1b1 - Browse repository at this point
Copy the full SHA e84d1b1View commit details -
qa: resolve errors flagged by Psalm
- Update to stable http-factory with support for PSR-7 v2. - Updates to add settings that will be required with Psalm 6. - Removes some unnecessary type checks, as parameter type declarations are now present. - Updates tests to remove assertions about types when they are known. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b47c358 - Browse repository at this point
Copy the full SHA b47c358View commit details -
qa: fixes CS issues flagged by phpcs
Unused import statements Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 22eca5b - Browse repository at this point
Copy the full SHA 22eca5bView commit details -
qa: reinstate some of the invalid protocol version tests
We still need to test _string_ versions that resolve to unsupported protocol versions. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e324ad6 - Browse repository at this point
Copy the full SHA e324ad6View commit details -
qa: remove redundant assigments
Per @Xerkus Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 60d5459 - Browse repository at this point
Copy the full SHA 60d5459View commit details -
qa: remove unneeded psalm-suppressions
Per @Xerkus Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 72d8e24 - Browse repository at this point
Copy the full SHA 72d8e24View commit details -
qa: add missing param type declaration for `RequestTrait::withRequest…
…Target()` should be string! Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a086fd1 - Browse repository at this point
Copy the full SHA a086fd1View commit details -
qa: add string param declaration for
$version
argument of `MessageT……rait::validateProtocolVersion` We know it's a string internally, so we can mark it one here, and remove a redundant conditional. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6eb9ce6 - Browse repository at this point
Copy the full SHA 6eb9ce6View commit details -
qa: Make
$size
argument toUplaodedFile
constructor nullableSince the `UploadedFileFactoryInterface` allows nullable size, not allowing it here could lead to an error condition. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ddf9497 - Browse repository at this point
Copy the full SHA ddf9497View commit details -
qa: fix CS issues and update baseline to remove unused entries
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b5f2b9e - Browse repository at this point
Copy the full SHA b5f2b9eView commit details -
qa: rename method parameters to follow PSR-7 spec
- `ServerRequest` `getAttribute` and `withAttribute` methods: rename `$attribute` to `$name`. - `StreamFactory::createStreamFromFile()`: rename `$file` to `$filename` Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for be030a0 - Browse repository at this point
Copy the full SHA be030a0View commit details