Add Support for PHP 8.4, Upgrade to Laminas Coding Standard 3.0 and Fix Compatibility with Symfony Console 7.1 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the regression on latest job are due to this commit symfony/console@7cc16b1 after many try, all that i can do is tag symfony/console:7.1 in conflict before now |
This was referenced Nov 17, 2024
gsteel
reviewed
Nov 17, 2024
|
@gsteel this should be good to go |
…ndard:^3 Signed-off-by: fezfez <[email protected]>
|
@gsteel build is green even with symfony/console 7.1 :) |
samsonasik
approved these changes
Nov 21, 2024
gsteel
approved these changes
Nov 21, 2024
gsteel
changed the title
Closed
|
@gsteel i dont think this is a regression in symfony 7.1 but a misuse in our side |
|
Cool - I'll adjust the title |
gsteel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.