Improve amd-fftw patch (re-fixes #74) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add inline copies of ifunc resolvers to fix the segfault. This allows us to turn --enable-dynamic-dispatcher back on (in case it ever does anyone any good). Signed-off-by: Jeroen Mostert <[email protected]>
|
Thanks, I heard that it should be able to get linux vm with epyc cpu and amd gpu from azure cloud that could be a good place to test this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add inline copies of ifunc resolvers to fix the segfault. This allows us to turn --enable-dynamic-dispatcher back on (in case it ever does anyone any good).
I've tested this against a rebuild of amd-fftw and seeing if
torioloads and gives back decoders, but an independent build is of course always welcome.I do not intend to submit this patch upstream, though I hereby freely give permission for anyone else to do so; the AMD repo seems extremely inactive and I'm not sure they aren't going to overhaul this whole ifunc business if/when they finally do get down to it (as they should).