Adjust notion of "Top-level property" to account for SHACL shapes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch addresses a use case where an ontology defines no or few rdfs:domain statements for its properties, instead relating properties to classes via SHACL shapes. If a property is associated to classes via SHACL property shapes within an ontology, it does not seem appropriate to treat the property as universally applicable. Co-authored-by: Alex Nelson <[email protected]> Signed-off-by: TJ Balon <[email protected]>
This patch should have no functional impact, except possibly some speedup from a braces encapsulation. Signed-off-by: Alex Nelson <[email protected]>
Review of the SHACL specification showed the sh:targetClass is not explicitly required under certain conditions, cited in getPropsApplicableByShapes. Signed-off-by: Alex Nelson <[email protected]>
|
Apologies for the in-flight update, but review of the SHACL specification showed one of the triples we had thought was explicitly required could be inferred from other conditions. The query now behaves more in line with the SHACL specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will address use cases where an ontology may define no or few rdfs:domain statements for its properties, instead relating properties to classes via SHACL shapes. If a property is associated to classes via SHACL property shapes within an ontology, it does not seem appropriate to treat the property as universally applicable.
Contained is a new method in the SparqlHelper class, which will find find the properties that should not be "top-level" due to applying to a class as a SHACL PropertyShape, and adjust the "Top-level property" based on this query.
Please advise if there is a better approach to solving this case where an ontology may utilize OWL, SHACL, or both.