Conversation
ilitteri
added a commit
that referenced
this pull request
Dec 20, 2022
* Refactor stdlib into a separate noir library (#1) * Remove std_lib package * Update path_to_stdlib Given that now the stdlib is a standalone nargo crate * Copy stdlib nargo crate to the native config dir * Move stdlib to the package manager level As a standalone nargo crate * Add build.rs dependencies * Return aztec_backend dependency back to its origin commit as it was modified accidentally. * Abstract driver module from the stdlib addition Now the stdlib addition is a responsibility for nargo. Note: It needs to add it before invoking into_compiled_program in order for the resolver to find the stdlib as a dependency of the crate. * cargo fmt * Change needless pass value This argument was passed by value, but not consumed in the function body * Update file_compiles for tests * Move tests to the package manager level as well * Add tests for the build cmd To ensure that the changes made work as expected * cargo fmt * Move the stdlib to the top level (#2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Already linked in the PR for noir)
Description
Summary of changes
This PR moves the stdlib to the top level as discussed with the Noir's team.
Dependency additions / changes
N/A
Test additions / changes
N/A
Checklist
cargo fmtwith default settings.Additional context
This was the easiest thing to do but let me know if the idea for the stdlib is to stay as an independent Rust crate and I'll make sure it is.