fix: update process_execution_payload and fix spec test#485
Merged
MegaRedHand merged 4 commits intomainfrom Nov 29, 2023
Merged
fix: update process_execution_payload and fix spec test#485MegaRedHand merged 4 commits intomainfrom
process_execution_payload and fix spec test#485MegaRedHand merged 4 commits intomainfrom
Conversation
MegaRedHand
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The previous spec test version considered "bad_parent_hash_first_payload" to be a valid testcase (post was not null), but this has been fixed in this PR ethereum/consensus-specs#3350
In our code we were using the simplified version of
process_execution_payloadso this was having issues with the test.Description
v1.4.0-alpha.0process_execution_payloadto take a beacon body instead of an execution payload (per spec)Patchis not an option since the code is inliband Patch is atestdependency. Maybe we can move the runners code to test but this is not trivial.