-
Notifications
You must be signed in to change notification settings - Fork 201
feat(l1): implement noopTracer for debug trace endpoints #6694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7970f49
feat(l1): implement noopTracer for debug trace endpoints
azteca1998 e68699c
test(rpc): add unit tests for noopTracer and tracing handlers
azteca1998 778ffc9
test(rpc): add e2e integration test for noopTracer
azteca1998 218f834
fix(rpc): noopTracer now executes transactions instead of skipping
azteca1998 ea80e96
style: run cargo fmt on test and source files
azteca1998 28da6c4
fix(rpc): noopTracer replays through EVM with no tracer attached
azteca1998 1d70566
docs(rpc): clarify noopTracer mechanism divergence from geth
azteca1998 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional consistency port from the duplicate #6657. Here the target tx is folded into the replay by stopping at
tx_index + 1. The sibling tracers (trace_tx_prestate,trace_tx_opcodes) instead replay[0, tx_index)and then run the target tx through a dedicated step — and #6657's noop path follows that same shape (rerun_block(Some(tx_index))+ a separatetrace_tx_noop(target)).For a noop the result is identical either way, so this is purely about keeping the module uniform:
Non-blocking; adopt only if you want parity with the prestate/opcode paths. The current
Some(tx_index + 1)form is correct as-is.