-
Notifications
You must be signed in to change notification settings - Fork 127
chore(l2): add help for tdx failure jobs #5367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a helpful error message to TDX prover build jobs that provides guidance when the build fails. The message instructs developers to run make update-cargo-lock from the project root as a potential fix.
Key Changes:
- Added fallback help message to
make image.rawcommand in TDX build workflows to assist with troubleshooting build failures
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/pr-main_l2_tdx_build.yaml |
Added help message to make image.raw command that displays when the build fails |
.github/workflows/pr-main_l2.yaml |
Attempted to add help message but incorrectly attached it to the cd command instead of make image.raw |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
JereSalo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If make image.raw fails, the echo command runs, and the entire step still returns success. The step will NOT fail the GitHub Actions job.
|
Suggestion: |
Done here 311491b |
|
great job |
Motivation
We want to show a quick fix for building the tdx prover