Skip to content

Conversation

@tomip01
Copy link
Contributor

@tomip01 tomip01 commented Nov 14, 2025

Motivation

We want to show a quick fix for building the tdx prover

Copilot AI review requested due to automatic review settings November 14, 2025 21:26
@tomip01 tomip01 requested a review from a team as a code owner November 14, 2025 21:26
Copilot finished reviewing on behalf of tomip01 November 14, 2025 21:29
@github-actions github-actions bot added the L2 Rollup client label Nov 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a helpful error message to TDX prover build jobs that provides guidance when the build fails. The message instructs developers to run make update-cargo-lock from the project root as a potential fix.

Key Changes:

  • Added fallback help message to make image.raw command in TDX build workflows to assist with troubleshooting build failures

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/pr-main_l2_tdx_build.yaml Added help message to make image.raw command that displays when the build fails
.github/workflows/pr-main_l2.yaml Attempted to add help message but incorrectly attached it to the cd command instead of make image.raw

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@JereSalo JereSalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If make image.raw fails, the echo command runs, and the entire step still returns success. The step will NOT fail the GitHub Actions job.

@github-project-automation github-project-automation bot moved this to Requires Changes in ethrex_l2 Nov 14, 2025
@JereSalo
Copy link
Contributor

Suggestion: make image.raw || { echo "..."; exit 1; }

@tomip01
Copy link
Contributor Author

tomip01 commented Nov 17, 2025

Suggestion: make image.raw || { echo "..."; exit 1; }

Done here 311491b

@tomip01 tomip01 enabled auto-merge November 17, 2025 19:54
@JereSalo
Copy link
Contributor

great job

@tomip01 tomip01 added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit 1be3fe7 Nov 17, 2025
45 of 53 checks passed
@tomip01 tomip01 deleted the help_tdx_build branch November 17, 2025 21:11
@github-project-automation github-project-automation bot moved this from Requires Changes to Done in ethrex_l2 Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L2 Rollup client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants