Skip to content

feat(l1): print out client version for latest snap sync upon startup #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(l1): print out client version for latest snap sync upon startup #5330

wants to merge 2 commits into from

Conversation

@fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Nov 13, 2025 •
edited
Loading

Motivation
Keep track of the client version used in the latest snap sync cycle and print it out upon startup

Description

  • Save the client version upon snap sync completion on the Store
  • Upon startup print out the client version for the latest completed snap sync if available

@github-actions github-actions bot added the L1 Ethereum client label Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Lines of code report

Total lines added: 37
Total lines removed: 0
Total lines changed: 37

Detailed view 
+---------------------------------------------+-------+------+
| File                                        | Lines | Diff |
+---------------------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs           | 447   | +3   |
+---------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/sync.rs        | 1384  | +3   |
+---------------------------------------------+-------+------+
| ethrex/crates/storage/api.rs                | 248   | +2   |
+---------------------------------------------+-------+------+
| ethrex/crates/storage/store.rs              | 1527  | +6   |
+---------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/in_memory.rs | 638   | +8   |
+---------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/rocksdb.rs   | 1611  | +15  |
+---------------------------------------------+-------+------+

@fmoletta fmoletta marked this pull request as ready for review November 13, 2025 20:55
@fmoletta fmoletta requested a review from a team as a code owner November 13, 2025 20:55
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Nov 13, 2025
@mpaulucci
Copy link
Collaborator

mpaulucci commented Nov 13, 2025

why do we need this?

mpaulucci
mpaulucci reviewed Nov 14, 2025
View reviewed changes
cmd/ethrex/initializers.rs
store.generate_flatkeyvalue()?;

if let Some(latest_snap_client_version) = store.get_snap_client_version().await? {
info!("Latest snap sync performed at client version {latest_snap_client_version}");
Copy link
Collaborator

@mpaulucci mpaulucci Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpaulucci mpaulucci mpaulucci left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@fmoletta fmoletta

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: In Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fmoletta @mpaulucci