Skip to content

Conversation

@ManuelBilbao
Copy link
Contributor

Motivation

We use ethrex --dev as L1 in L2 tests and it'd be useful to test in an Osaka network.

Description

Use GetPayloadV5 in dev block producer

@ManuelBilbao ManuelBilbao self-assigned this Oct 29, 2025
Copilot AI review requested due to automatic review settings October 29, 2025 15:04
@ManuelBilbao ManuelBilbao requested a review from a team as a code owner October 29, 2025 15:04
@ManuelBilbao ManuelBilbao added the L1 Ethereum client label Oct 29, 2025
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Ethereum Engine API from v4 to v5 to support the Osaka fork. The changes include updating function calls, request types, and adding Osaka fork activation time to the genesis configuration.

  • Updated engine_getPayloadV4 to engine_getPayloadV5 across client and server implementations
  • Added osakaTime configuration to the L1 development genesis file
  • Updated Cargo.lock dependencies for aligned-sdk and ethrex-core

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tooling/reorgs/src/simulator.rs Updated simulator to use engine_getPayloadV5
crates/networking/rpc/clients/auth/mod.rs Renamed function and updated request type from v4 to v5
crates/blockchain/dev/block_producer.rs Updated block producer to use v5 API and updated debug/error messages
fixtures/genesis/l1-dev.json Added osakaTime fork activation timestamp
tooling/Cargo.lock Updated aligned-sdk dependency and added serde_bytes and hex dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ManuelBilbao ManuelBilbao added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit 105ced6 Oct 30, 2025
40 checks passed
@ManuelBilbao ManuelBilbao deleted the l1_dev_osaka branch October 30, 2025 13:34
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants