Skip to content

chore(l1): register block building metric and dashboard #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2025
Merged

chore(l1): register block building metric and dashboard #4879

merged 4 commits into from
Oct 15, 2025

Conversation

edg-l
Copy link
Contributor

@edg-l edg-l commented Oct 15, 2025 •
edited
Loading

Motivation
In #4878 we forgot to register the metric so prometheus picks it up

image

@edg-l edg-l requested a review from a team as a code owner October 15, 2025 12:01
@edg-l edg-l changed the title fix(l1): register block building metric chore(l1): register block building metric Oct 15, 2025
@github-actions github-actions bot added the L1 Ethereum client label Oct 15, 2025
@github-actions GitHub Actions
Copy link

Lines of code report

Total lines added: 6
Total lines removed: 0
Total lines changed: 6

Detailed view 
+----------------------------------------------------+-------+------+
| File                                               | Lines | Diff |
+----------------------------------------------------+-------+------+
| ethrex/crates/blockchain/metrics/metrics_blocks.rs | 110   | +6   |
+----------------------------------------------------+-------+------+

@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Oct 15, 2025
@edg-l edg-l enabled auto-merge October 15, 2025 12:07
@edg-l edg-l disabled auto-merge October 15, 2025 12:11
@edg-l edg-l enabled auto-merge October 15, 2025 12:23
@edg-l edg-l changed the title chore(l1): register block building metric chore(l1): register block building metric and dashboard Oct 15, 2025
Arkenan
Arkenan approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edg-l edg-l added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit 7c234d6 Oct 15, 2025
28 checks passed
@edg-l edg-l deleted the register_blockbuilding_metric branch October 15, 2025 13:22
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arkenan Arkenan Arkenan approved these changes

@azteca1998 azteca1998 azteca1998 approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees

@edg-l edg-l

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edg-l @Arkenan @azteca1998 @MegaRedHand