ci(l1): reenable engine-cancun hive simulation
#4876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
changed the title
engine-cancun and disable rpc-compat simulations
mpaulucci
commented
Oct 15, 2025
|
|
||
| if ! command -v jq >/dev/null 2>&1; then | ||
| echo "jq is required to parse Hive results but was not found in PATH" | ||
| exit 1 |
There was a problem hiding this comment.
script done by Codex, low risk, no need to review
There was a problem hiding this comment.
The script was changed to basically group the logs for each tests in a separate folder
There was a problem hiding this comment.
Pull Request Overview
This PR updates CI to improve Hive test coverage by re-enabling Cancun engine simulations and disabling the rpc-compat suite, and enhances failure artifact generation.
- Re-enable engine-cancun Hive simulations; disable rpc-compat scenarios tied to pre-merge genesis.
- Reduce Hive simulation parallelism and increase log verbosity in the L1 workflow.
- Expand check-hive-results.sh to extract per-client log snippets for failing cases, with slugifying and a python3 prerequisite.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/pr-main_l1.yaml | Updates the Hive matrix (disable rpc-compat, enable engine-cancun) and adjusts sim flags (parallelism/loglevel). |
| .github/scripts/check-hive-results.sh | Adds slugify, requires python3, and generates per-client log snippets for failing Hive test cases. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JereSalo
approved these changes
Oct 15, 2025
mpaulucci
changed the title
engine-cancun and disable rpc-compat simulationsengine-cancun hive simulation
MegaRedHand
reviewed
Oct 16, 2025
| hive_repository: ${{ matrix.hive_repository }} | ||
| hive_version: ${{ matrix.hive_version }} | ||
| hive_repository: ethereum/hive | ||
| hive_version: 7709e5892146c793307da072e1593f48039a7e4b |
There was a problem hiding this comment.
What version is this? Can we add a comment with the numerical version or at least the date?
MegaRedHand
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve Hive test coverage
Description