refactor(l1): improve the way we remove ONLY the storage of an account

[JereSalo]

Motivation

• For removing just the storage of an account we were doing something "dirty", which was inserting 2 updates for the same account. One with its destruction and another one with the changes, this cleans that up.

Description

• Add removed_storage attribute to AccountUpdate
  • If we want to remove whole storage of an account we just change the storage root of the account to the empty root.

Closes #3321

[github-actions]

Lines of code report

Total lines added: 14
Total lines removed: 12
Total lines changed: 26

Detailed view

+-------------------------------------------------------+-------+------+
| File                                                  | Lines | Diff |
+-------------------------------------------------------+-------+------+
| ethrex/crates/common/types/account_update.rs          | 41    | +2   |
+-------------------------------------------------------+-------+------+
| ethrex/crates/common/types/block_execution_witness.rs | 426   | +3   |
+-------------------------------------------------------+-------+------+
| ethrex/crates/common/utils.rs                         | 63    | +1   |
+-------------------------------------------------------+-------+------+
| ethrex/crates/l2/common/src/state_diff.rs             | 548   | +1   |
+-------------------------------------------------------+-------+------+
| ethrex/crates/storage/store.rs                        | 1436  | +6   |
+-------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/db/gen_db.rs                | 326   | -12  |
+-------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state/runner/revm_db.rs       | 198   | +1   |
+-------------------------------------------------------+-------+------+

[github-actions]

Benchmark Results Comparison

No significant difference was registered for any benchmark run.

Detailed Results

Benchmark Results: BubbleSort

Command	Mean [s]	Min [s]	Max [s]	Relative
main_revm_BubbleSort	4.755 ± 0.011	4.746	4.783	1.02 ± 0.01
main_levm_BubbleSort	4.676 ± 0.021	4.651	4.702	1.01 ± 0.01
pr_revm_BubbleSort	4.755 ± 0.016	4.733	4.786	1.02 ± 0.01
pr_levm_BubbleSort	4.651 ± 0.023	4.612	4.681	1.00

Benchmark Results: ERC20Approval

Command	Mean [s]	Min [s]	Max [s]	Relative
main_revm_ERC20Approval	1.578 ± 0.014	1.568	1.604	1.01 ± 0.01
main_levm_ERC20Approval	1.637 ± 0.009	1.626	1.655	1.04 ± 0.01
pr_revm_ERC20Approval	1.569 ± 0.010	1.561	1.595	1.00
pr_levm_ERC20Approval	1.638 ± 0.007	1.624	1.648	1.04 ± 0.01

Benchmark Results: ERC20Mint

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
main_revm_ERC20Mint	185.7 ± 0.5	184.6	186.3	1.00
main_levm_ERC20Mint	198.6 ± 2.1	196.3	202.9	1.07 ± 0.01
pr_revm_ERC20Mint	187.9 ± 0.8	186.9	189.3	1.01 ± 0.00
pr_levm_ERC20Mint	198.2 ± 2.3	196.5	204.0	1.07 ± 0.01

Benchmark Results: ERC20Transfer

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
main_revm_ERC20Transfer	363.3 ± 15.3	356.6	406.6	1.01 ± 0.04
main_levm_ERC20Transfer	382.6 ± 0.9	380.6	383.7	1.06 ± 0.01
pr_revm_ERC20Transfer	360.8 ± 4.5	357.8	369.7	1.00
pr_levm_ERC20Transfer	381.9 ± 1.4	379.7	384.3	1.06 ± 0.01

Benchmark Results: Factorial

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
main_revm_Factorial	242.8 ± 1.1	241.3	245.1	1.00
main_levm_Factorial	279.3 ± 2.7	276.6	285.2	1.15 ± 0.01
pr_revm_Factorial	245.1 ± 7.0	242.2	265.1	1.01 ± 0.03
pr_levm_Factorial	283.5 ± 8.9	277.5	301.4	1.17 ± 0.04

Benchmark Results: FactorialRecursive

Command	Mean [s]	Min [s]	Max [s]	Relative
main_revm_FactorialRecursive	1.711 ± 0.045	1.607	1.771	1.00
main_levm_FactorialRecursive	8.611 ± 0.688	6.679	8.998	5.03 ± 0.42
pr_revm_FactorialRecursive	1.718 ± 0.033	1.647	1.758	1.00 ± 0.03
pr_levm_FactorialRecursive	8.821 ± 0.089	8.668	8.957	5.16 ± 0.14

Benchmark Results: Fibonacci

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
main_revm_Fibonacci	217.2 ± 0.4	216.8	217.9	1.00
main_levm_Fibonacci	249.2 ± 1.7	247.6	253.6	1.15 ± 0.01
pr_revm_Fibonacci	218.6 ± 6.2	213.9	235.6	1.01 ± 0.03
pr_levm_Fibonacci	249.8 ± 1.1	248.8	252.4	1.15 ± 0.01

Benchmark Results: FibonacciRecursive

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
main_revm_FibonacciRecursive	908.4 ± 12.8	891.9	931.3	1.02 ± 0.02
main_levm_FibonacciRecursive	1041.5 ± 4.7	1035.2	1048.1	1.17 ± 0.01
pr_revm_FibonacciRecursive	891.4 ± 8.6	874.0	901.1	1.00
pr_levm_FibonacciRecursive	1037.1 ± 6.6	1028.4	1048.4	1.16 ± 0.01

Benchmark Results: ManyHashes

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
main_revm_ManyHashes	12.6 ± 0.1	12.5	12.8	1.00
main_levm_ManyHashes	14.1 ± 0.1	14.0	14.2	1.11 ± 0.01
pr_revm_ManyHashes	12.6 ± 0.1	12.5	12.7	1.00 ± 0.01
pr_levm_ManyHashes	14.1 ± 0.2	13.9	14.5	1.12 ± 0.02

Benchmark Results: MstoreBench

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
main_revm_MstoreBench	275.7 ± 2.9	271.8	279.1	1.00 ± 0.02
main_levm_MstoreBench	757.3 ± 4.0	754.0	767.9	2.75 ± 0.05
pr_revm_MstoreBench	275.5 ± 4.4	271.3	284.0	1.00
pr_levm_MstoreBench	755.3 ± 2.2	752.0	759.9	2.74 ± 0.04

Benchmark Results: Push

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
main_revm_Push	303.0 ± 1.0	301.9	305.2	1.00
main_levm_Push	830.1 ± 5.0	826.2	841.7	2.74 ± 0.02
pr_revm_Push	303.9 ± 2.1	302.2	309.0	1.00 ± 0.01
pr_levm_Push	831.2 ± 1.0	829.7	832.6	2.74 ± 0.01

Benchmark Results: SstoreBench_no_opt

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
main_revm_SstoreBench_no_opt	220.0 ± 0.3	219.7	220.6	2.39 ± 0.03
main_levm_SstoreBench_no_opt	93.3 ± 1.1	90.3	94.0	1.01 ± 0.02
pr_revm_SstoreBench_no_opt	219.6 ± 0.5	218.7	220.2	2.39 ± 0.03
pr_levm_SstoreBench_no_opt	92.0 ± 1.3	90.1	93.7	1.00

[JereSalo]

We could improve code around this so that the get state transitions of revm makes use of removed_storage but I consider it to be irrelevant, we are going to remove this code whenever we can anyway