build: add Github actions boilerplate#3
Merged
Merged
Conversation
MegaRedHand
approved these changes
May 31, 2024
Collaborator
MegaRedHand
left a comment
MegaRedHand
left a comment
There was a problem hiding this comment.
LGTM. Should we mention this in the readme?
1 task
This was referenced Feb 6, 2026
This was referenced Feb 11, 2026
3 tasks
ilitteri
added a commit
that referenced
this pull request
May 5, 2026
… and intrinsic_state_gas_charged
Per steel-team confirmed cross-client bug (multiple clients, ~8 tests):
"block.state_gas_used does not include eip7702 state refund. It is higher
than expected."
eip7702_set_access_code previously only credited state_gas_reservoir for
each existing authority (sender-side refund at tx finalize), leaving
state_gas_used unchanged. block.state_gas_used = max(state_gas_used,
state_gas_reservoir_initial - state_gas_reservoir) was therefore higher
than spec by STATE_BYTES_PER_NEW_ACCOUNT * CPSB per existing authority.
Add the missing block-level effects:
1. state_gas_reservoir += STATE_NEW (sender refund, was already done)
2. state_gas_used -= STATE_NEW (block accounting)
3. intrinsic_state_gas_charged -= STATE_NEW (preserve floor invariant
asserted in vm.rs)
Reproduced on bal-devnet-6 (geth + besu + ethrex on ethrex-office-3):
ethrex over-counted gasUsed on canonical block 16 by exactly 131,488
(= STATE_BYTES_PER_NEW_ACCOUNT * CPSB) plus a small residual of 3,893
(likely steel-team bug #3, deferred). With this patch the 131,488
component disappears; chain converges with geth + besu past head 316
(was diverging at block 16).
edg-l
pushed a commit
that referenced
this pull request
May 6, 2026
… and intrinsic_state_gas_charged
Per steel-team confirmed cross-client bug (multiple clients, ~8 tests):
"block.state_gas_used does not include eip7702 state refund. It is higher
than expected."
eip7702_set_access_code previously only credited state_gas_reservoir for
each existing authority (sender-side refund at tx finalize), leaving
state_gas_used unchanged. block.state_gas_used = max(state_gas_used,
state_gas_reservoir_initial - state_gas_reservoir) was therefore higher
than spec by STATE_BYTES_PER_NEW_ACCOUNT * CPSB per existing authority.
Add the missing block-level effects:
1. state_gas_reservoir += STATE_NEW (sender refund, was already done)
2. state_gas_used -= STATE_NEW (block accounting)
3. intrinsic_state_gas_charged -= STATE_NEW (preserve floor invariant
asserted in vm.rs)
Reproduced on bal-devnet-6 (geth + besu + ethrex on ethrex-office-3):
ethrex over-counted gasUsed on canonical block 16 by exactly 131,488
(= STATE_BYTES_PER_NEW_ACCOUNT * CPSB) plus a small residual of 3,893
(likely steel-team bug #3, deferred). With this patch the 131,488
component disappears; chain converges with geth + besu past head 316
(was diverging at block 16).
edg-l
pushed a commit
that referenced
this pull request
May 6, 2026
… and intrinsic_state_gas_charged
Per steel-team confirmed cross-client bug (multiple clients, ~8 tests):
"block.state_gas_used does not include eip7702 state refund. It is higher
than expected."
eip7702_set_access_code previously only credited state_gas_reservoir for
each existing authority (sender-side refund at tx finalize), leaving
state_gas_used unchanged. block.state_gas_used = max(state_gas_used,
state_gas_reservoir_initial - state_gas_reservoir) was therefore higher
than spec by STATE_BYTES_PER_NEW_ACCOUNT * CPSB per existing authority.
Add the missing block-level effects:
1. state_gas_reservoir += STATE_NEW (sender refund, was already done)
2. state_gas_used -= STATE_NEW (block accounting)
3. intrinsic_state_gas_charged -= STATE_NEW (preserve floor invariant
asserted in vm.rs)
Reproduced on bal-devnet-6 (geth + besu + ethrex on ethrex-office-3):
ethrex over-counted gasUsed on canonical block 16 by exactly 131,488
(= STATE_BYTES_PER_NEW_ACCOUNT * CPSB) plus a small residual of 3,893
(likely steel-team bug #3, deferred). With this patch the 131,488
component disappears; chain converges with geth + besu past head 316
(was diverging at block 16).
edg-l
pushed a commit
that referenced
this pull request
May 6, 2026
… and intrinsic_state_gas_charged
Per steel-team confirmed cross-client bug (multiple clients, ~8 tests):
"block.state_gas_used does not include eip7702 state refund. It is higher
than expected."
eip7702_set_access_code previously only credited state_gas_reservoir for
each existing authority (sender-side refund at tx finalize), leaving
state_gas_used unchanged. block.state_gas_used = max(state_gas_used,
state_gas_reservoir_initial - state_gas_reservoir) was therefore higher
than spec by STATE_BYTES_PER_NEW_ACCOUNT * CPSB per existing authority.
Add the missing block-level effects:
1. state_gas_reservoir += STATE_NEW (sender refund, was already done)
2. state_gas_used -= STATE_NEW (block accounting)
3. intrinsic_state_gas_charged -= STATE_NEW (preserve floor invariant
asserted in vm.rs)
Reproduced on bal-devnet-6 (geth + besu + ethrex on ethrex-office-3):
ethrex over-counted gasUsed on canonical block 16 by exactly 131,488
(= STATE_BYTES_PER_NEW_ACCOUNT * CPSB) plus a small residual of 3,893
(likely steel-team bug #3, deferred). With this patch the 131,488
component disappears; chain converges with geth + besu past head 316
(was diverging at block 16).
edg-l
pushed a commit
that referenced
this pull request
May 6, 2026
… and intrinsic_state_gas_charged
Per steel-team confirmed cross-client bug (multiple clients, ~8 tests):
"block.state_gas_used does not include eip7702 state refund. It is higher
than expected."
eip7702_set_access_code previously only credited state_gas_reservoir for
each existing authority (sender-side refund at tx finalize), leaving
state_gas_used unchanged. block.state_gas_used = max(state_gas_used,
state_gas_reservoir_initial - state_gas_reservoir) was therefore higher
than spec by STATE_BYTES_PER_NEW_ACCOUNT * CPSB per existing authority.
Add the missing block-level effects:
1. state_gas_reservoir += STATE_NEW (sender refund, was already done)
2. state_gas_used -= STATE_NEW (block accounting)
3. intrinsic_state_gas_charged -= STATE_NEW (preserve floor invariant
asserted in vm.rs)
Reproduced on bal-devnet-6 (geth + besu + ethrex on ethrex-office-3):
ethrex over-counted gasUsed on canonical block 16 by exactly 131,488
(= STATE_BYTES_PER_NEW_ACCOUNT * CPSB) plus a small residual of 3,893
(likely steel-team bug #3, deferred). With this patch the 131,488
component disappears; chain converges with geth + besu past head 316
(was diverging at block 16).
edg-l
pushed a commit
that referenced
this pull request
May 7, 2026
… and intrinsic_state_gas_charged
Per steel-team confirmed cross-client bug (multiple clients, ~8 tests):
"block.state_gas_used does not include eip7702 state refund. It is higher
than expected."
eip7702_set_access_code previously only credited state_gas_reservoir for
each existing authority (sender-side refund at tx finalize), leaving
state_gas_used unchanged. block.state_gas_used = max(state_gas_used,
state_gas_reservoir_initial - state_gas_reservoir) was therefore higher
than spec by STATE_BYTES_PER_NEW_ACCOUNT * CPSB per existing authority.
Add the missing block-level effects:
1. state_gas_reservoir += STATE_NEW (sender refund, was already done)
2. state_gas_used -= STATE_NEW (block accounting)
3. intrinsic_state_gas_charged -= STATE_NEW (preserve floor invariant
asserted in vm.rs)
Reproduced on bal-devnet-6 (geth + besu + ethrex on ethrex-office-3):
ethrex over-counted gasUsed on canonical block 16 by exactly 131,488
(= STATE_BYTES_PER_NEW_ACCOUNT * CPSB) plus a small residual of 3,893
(likely steel-team bug #3, deferred). With this patch the 131,488
component disappears; chain converges with geth + besu past head 316
(was diverging at block 16).
edg-l
pushed a commit
that referenced
this pull request
May 7, 2026
… and intrinsic_state_gas_charged
Per steel-team confirmed cross-client bug (multiple clients, ~8 tests):
"block.state_gas_used does not include eip7702 state refund. It is higher
than expected."
eip7702_set_access_code previously only credited state_gas_reservoir for
each existing authority (sender-side refund at tx finalize), leaving
state_gas_used unchanged. block.state_gas_used = max(state_gas_used,
state_gas_reservoir_initial - state_gas_reservoir) was therefore higher
than spec by STATE_BYTES_PER_NEW_ACCOUNT * CPSB per existing authority.
Add the missing block-level effects:
1. state_gas_reservoir += STATE_NEW (sender refund, was already done)
2. state_gas_used -= STATE_NEW (block accounting)
3. intrinsic_state_gas_charged -= STATE_NEW (preserve floor invariant
asserted in vm.rs)
Reproduced on bal-devnet-6 (geth + besu + ethrex on ethrex-office-3):
ethrex over-counted gasUsed on canonical block 16 by exactly 131,488
(= STATE_BYTES_PER_NEW_ACCOUNT * CPSB) plus a small residual of 3,893
(likely steel-team bug #3, deferred). With this patch the 131,488
component disappears; chain converges with geth + besu past head 316
(was diverging at block 16).
edg-l
pushed a commit
that referenced
this pull request
May 8, 2026
… and intrinsic_state_gas_charged
Per steel-team confirmed cross-client bug (multiple clients, ~8 tests):
"block.state_gas_used does not include eip7702 state refund. It is higher
than expected."
eip7702_set_access_code previously only credited state_gas_reservoir for
each existing authority (sender-side refund at tx finalize), leaving
state_gas_used unchanged. block.state_gas_used = max(state_gas_used,
state_gas_reservoir_initial - state_gas_reservoir) was therefore higher
than spec by STATE_BYTES_PER_NEW_ACCOUNT * CPSB per existing authority.
Add the missing block-level effects:
1. state_gas_reservoir += STATE_NEW (sender refund, was already done)
2. state_gas_used -= STATE_NEW (block accounting)
3. intrinsic_state_gas_charged -= STATE_NEW (preserve floor invariant
asserted in vm.rs)
Reproduced on bal-devnet-6 (geth + besu + ethrex on ethrex-office-3):
ethrex over-counted gasUsed on canonical block 16 by exactly 131,488
(= STATE_BYTES_PER_NEW_ACCOUNT * CPSB) plus a small residual of 3,893
(likely steel-team bug #3, deferred). With this patch the 131,488
component disappears; chain converges with geth + besu past head 316
(was diverging at block 16).
9 tasks
edg-l
added a commit
that referenced
this pull request
May 21, 2026
Replace fragile line-number references in seed_db_from_bal doc with descriptive context. Add a brief note on the contains_key + get_mut fast paths in load_account explaining why a direct get_mut is not expressible (NLL problem case #3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.