feat: add simple RLP encode implementation#10
Merged
Merged
Conversation
juanbono
changed the title
juanbono
changed the title
This was referenced Feb 9, 2026
jason-h23
referenced
this pull request
in tokamak-network/ethrex
Feb 25, 2026
Update roadmap, status, and execution order. Phase 9 now ~50% complete. Feature #10 Continuous Benchmarking advances to ~50%. Next: C-2 (LLVM provisioning) and B-3 (EIP-7928 BAL recording).
edg-l
added a commit
that referenced
this pull request
May 5, 2026
apply_trie_updates Phase 2 was sending FKVGeneratorControlMessage::Stop and ::Continue on every commitable layer regardless of backend_kind. For Mpt this coordinates with the running flatkeyvalue_generator. For Binary/Transition the generator is either never running (Binary FKV is populated inline by binary_commit_nodes_to_disk) or permanently stopped at activation (Transition: stop_fkv_generator() in activate() step 2). The post-activation path produced "Error while generating FlatKeyValue: Unexpected Stop message" because the stopped generator was blocked at mpt_wiring.rs:1085 waiting for Continue (per its PivotChanged protocol) and instead received a 2nd Stop from Phase 2. Cosmetic for chain progress (the let _ = ... ignores send errors and the generator thread just exits), but a real protocol violation worth silencing. Fix: gate both fkv_ctl.send(Stop) and send(Continue) calls on backend_kind == BackendKind::Mpt. Binary and Transition skip messaging entirely. Also add to phase-7-handoff.md: - Bug 7 description and fix (FCU has_state_root MPT-only check, fixed in eea035e). - Bug 8 description and fix (this commit). - Bug 9 (open): gas mismatch at switch+21 on run #10. Distinct from Bug 6 family; suspect cross-block storage read returns stale value causing SSTORE net-gas-metering divergence. Diagnosis path noted. - Known parity gap: binary trie should have a background FKV generator for full symmetry with MPT (out-of-scope for Phase 7/8; Phase 11+). ethrex-storage 49/49, ethrex-blockchain 7/7 tests pass; workspace cargo check clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds RLP encoding for many types.
Description
Closes #issue_number