Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust to 1.83.0 #975

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Update rust to 1.83.0 #975

merged 2 commits into from
Dec 18, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Dec 16, 2024

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.706 ± 0.380 11.102 12.027 8.68 ± 0.28
cairo-native (embedded AOT) 3.417 ± 0.022 3.388 3.449 2.53 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 3.221 ± 0.013 3.208 3.251 2.39 ± 0.01
cairo-native (standalone AOT with -march=native) 1.349 ± 0.001 1.348 1.351 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.214 ± 0.294 10.938 11.731 143.81 ± 5.09
cairo-native (embedded AOT) 3.011 ± 0.045 2.963 3.083 38.61 ± 1.08
cairo-native (embedded JIT using LLVM's ORC Engine) 2.756 ± 0.021 2.731 2.798 35.34 ± 0.88
cairo-native (standalone AOT with -march=native) 0.078 ± 0.002 0.077 0.088 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.359 ± 0.035 4.319 4.414 2209.66 ± 53.07
cairo-native (embedded AOT) 3.068 ± 0.030 3.031 3.114 1555.46 ± 38.34
cairo-native (embedded JIT using LLVM's ORC Engine) 2.958 ± 0.028 2.919 3.020 1499.57 ± 36.87
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.002 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.255 ± 0.027 4.214 4.304 17.55 ± 0.11
cairo-native (embedded AOT) 3.138 ± 0.025 3.104 3.185 12.94 ± 0.10
cairo-native (embedded JIT using LLVM's ORC Engine) 3.091 ± 0.052 3.027 3.166 12.75 ± 0.22
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.242 0.243 1.00

Copy link

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 3.179 ± 0.016 3.153 3.199 1.00
base factorial_2M.cairo (AOT) 3.375 ± 0.012 3.360 3.392 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 3.151 ± 0.013 3.137 3.178 1.00
head factorial_2M.cairo (AOT) 3.334 ± 0.012 3.320 3.353 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.744 ± 0.023 2.716 2.789 1.00
base fib_2M.cairo (AOT) 2.940 ± 0.028 2.896 2.985 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 2.714 ± 0.018 2.680 2.741 1.00
head fib_2M.cairo (AOT) 2.898 ± 0.011 2.882 2.919 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 2.928 ± 0.033 2.876 3.001 1.00
base linear_search.cairo (AOT) 3.084 ± 0.045 3.043 3.176 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 2.912 ± 0.030 2.870 2.973 1.00
head linear_search.cairo (AOT) 3.002 ± 0.023 2.975 3.033 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.092 ± 0.046 3.030 3.160 1.00
base logistic_map.cairo (AOT) 3.202 ± 0.033 3.128 3.243 1.04 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 2.998 ± 0.016 2.970 3.018 1.00
head logistic_map.cairo (AOT) 3.074 ± 0.025 3.045 3.140 1.03 ± 0.01

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (4bd59e9) to head (dea0adf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #975   +/-   ##
=======================================
  Coverage   80.66%   80.66%           
=======================================
  Files         107      107           
  Lines       29325    29325           
=======================================
  Hits        23656    23656           
  Misses       5669     5669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l enabled auto-merge December 17, 2024 13:48
@edg-l edg-l added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 17, 2024
@edg-l edg-l added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 17, 2024
@edg-l edg-l added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 7ec1e3c Dec 18, 2024
32 checks passed
@edg-l edg-l deleted the upd_rust branch December 18, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants