Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panics in values.rs #925

Merged
merged 13 commits into from
Nov 25, 2024
Merged

Remove panics in values.rs #925

merged 13 commits into from
Nov 25, 2024

Conversation

FrancoGiachetta
Copy link
Contributor

  • src/values.rs

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Nov 14, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.489 ± 0.337 10.845 11.761 8.53 ± 0.25
cairo-native (embedded AOT) 3.397 ± 0.041 3.347 3.480 2.52 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 3.208 ± 0.030 3.175 3.258 2.38 ± 0.02
cairo-native (standalone AOT with -march=native) 1.348 ± 0.001 1.346 1.351 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.094 ± 0.385 10.764 11.873 142.36 ± 4.98
cairo-native (embedded AOT) 3.074 ± 0.033 3.028 3.120 39.44 ± 0.45
cairo-native (embedded JIT using LLVM's ORC Engine) 2.765 ± 0.029 2.730 2.836 35.47 ± 0.40
cairo-native (standalone AOT with -march=native) 0.078 ± 0.000 0.077 0.078 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.282 ± 0.034 4.243 4.358 17.70 ± 0.14
cairo-native (embedded AOT) 3.172 ± 0.023 3.147 3.209 13.12 ± 0.09
cairo-native (embedded JIT using LLVM's ORC Engine) 3.085 ± 0.030 3.044 3.151 12.76 ± 0.13
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.241 0.242 1.00

Copy link

github-actions bot commented Nov 14, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 3.312 ± 0.034 3.253 3.355 1.00
base factorial_2M.cairo (AOT) 3.470 ± 0.023 3.433 3.501 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 3.274 ± 0.026 3.258 3.345 1.00
head factorial_2M.cairo (AOT) 3.471 ± 0.013 3.451 3.489 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.814 ± 0.024 2.787 2.867 1.00
base fib_2M.cairo (AOT) 3.044 ± 0.038 2.971 3.114 1.08 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 2.826 ± 0.036 2.781 2.892 1.00
head fib_2M.cairo (AOT) 3.024 ± 0.027 2.994 3.068 1.07 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.110 ± 0.019 3.068 3.134 1.00
base logistic_map.cairo (AOT) 3.195 ± 0.026 3.165 3.238 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.134 ± 0.019 3.104 3.171 1.00
head logistic_map.cairo (AOT) 3.214 ± 0.026 3.181 3.275 1.03 ± 0.01

azteca1998
azteca1998 previously approved these changes Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.48%. Comparing base (107ff62) to head (561008a).

Files with missing lines Patch % Lines
src/values.rs 81.48% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   82.46%   82.48%   +0.01%     
==========================================
  Files         117      117              
  Lines       34392    34420      +28     
==========================================
+ Hits        28362    28391      +29     
+ Misses       6030     6029       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

edg-l
edg-l previously approved these changes Nov 15, 2024
@edg-l edg-l added the review-ready A PR that is ready for review label Nov 25, 2024
@edg-l edg-l added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 075b9ac Nov 25, 2024
32 checks passed
@edg-l edg-l deleted the rm-unwraps-values branch November 25, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants