-
Notifications
You must be signed in to change notification settings - Fork 49
Fix BoundedInt Sub libfunc #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DiegoCivi
wants to merge
1
commit into
main
Choose a base branch
from
fix-bi-sub
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
+ Coverage 81.45% 81.60% +0.14%
==========================================
Files 105 105
Lines 25862 25925 +63
==========================================
+ Hits 21065 21155 +90
+ Misses 4797 4770 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.846 ± 0.052 | 10.748 | 10.922 | 4.50 ± 0.05 |
cairo-native (embedded AOT) |
2.412 ± 0.026 | 2.373 | 2.447 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.488 ± 0.029 | 2.440 | 2.531 | 1.03 ± 0.02 |
Benchmark for program dict_snapshot
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
510.5 ± 4.3 | 503.7 | 515.6 | 1.00 |
cairo-native (embedded AOT) |
2094.9 ± 18.4 | 2052.9 | 2115.8 | 4.10 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2217.9 ± 36.5 | 2162.5 | 2301.0 | 4.34 ± 0.08 |
Benchmark for program factorial_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.723 ± 0.057 | 4.689 | 4.880 | 1.88 ± 0.03 |
cairo-native (embedded AOT) |
2.515 ± 0.016 | 2.499 | 2.554 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.550 ± 0.027 | 2.522 | 2.596 | 1.01 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.663 ± 0.018 | 4.644 | 4.701 | 2.23 ± 0.04 |
cairo-native (embedded AOT) |
2.095 ± 0.035 | 2.056 | 2.156 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.112 ± 0.021 | 2.080 | 2.151 | 1.01 ± 0.02 |
Benchmark for program heavy_circuit
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
9.665 ± 0.095 | 9.533 | 9.804 | 1.00 |
cairo-native (embedded AOT) |
14.696 ± 0.063 | 14.616 | 14.814 | 1.52 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
15.008 ± 0.147 | 14.772 | 15.170 | 1.55 ± 0.02 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
555.9 ± 10.4 | 544.7 | 581.3 | 1.00 |
cairo-native (embedded AOT) |
2139.4 ± 18.7 | 2122.8 | 2180.4 | 3.85 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2329.9 ± 34.6 | 2272.4 | 2385.1 | 4.19 ± 0.10 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
372.0 ± 5.3 | 364.7 | 383.2 | 1.00 |
cairo-native (embedded AOT) |
2221.8 ± 20.9 | 2198.3 | 2267.1 | 5.97 ± 0.10 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2385.7 ± 19.8 | 2358.8 | 2431.2 | 6.41 ± 0.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Closes #NA
Introduces Breaking Changes?
Yes/No.
starknet-blocks.ymlworkflow to use these PRs.These PRs should be merged after this one right away, in that order.
Checklist