-
Notifications
You must be signed in to change notification settings - Fork 49
GasReserve libfuncs #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
GasReserve libfuncs #1439
Conversation
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.859 ± 0.032 | 10.797 | 10.917 | 4.46 ± 0.03 |
cairo-native (embedded AOT) |
2.436 ± 0.015 | 2.410 | 2.463 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.548 ± 0.017 | 2.521 | 2.573 | 1.05 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
513.5 ± 3.8 | 509.2 | 522.8 | 1.00 |
cairo-native (embedded AOT) |
2134.7 ± 17.5 | 2119.9 | 2167.1 | 4.16 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2270.0 ± 19.3 | 2245.5 | 2298.9 | 4.42 ± 0.05 |
Benchmark for program factorial_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.725 ± 0.015 | 4.703 | 4.751 | 1.84 ± 0.01 |
cairo-native (embedded AOT) |
2.570 ± 0.013 | 2.554 | 2.593 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.633 ± 0.015 | 2.613 | 2.663 | 1.02 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.691 ± 0.022 | 4.662 | 4.719 | 2.21 ± 0.03 |
cairo-native (embedded AOT) |
2.125 ± 0.023 | 2.091 | 2.171 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.145 ± 0.018 | 2.119 | 2.177 | 1.01 ± 0.01 |
Benchmark for program heavy_circuit
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
9.602 ± 0.088 | 9.496 | 9.764 | 1.00 |
cairo-native (embedded AOT) |
13.552 ± 0.089 | 13.403 | 13.713 | 1.41 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
13.956 ± 0.059 | 13.890 | 14.036 | 1.45 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
555.9 ± 5.5 | 548.8 | 564.9 | 1.00 |
cairo-native (embedded AOT) |
2194.1 ± 17.2 | 2166.7 | 2222.5 | 3.95 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2319.9 ± 13.9 | 2301.9 | 2352.2 | 4.17 ± 0.05 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
375.4 ± 4.7 | 369.7 | 384.1 | 1.00 |
cairo-native (embedded AOT) |
2279.9 ± 14.8 | 2260.7 | 2309.0 | 6.07 ± 0.09 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2438.9 ± 18.8 | 2409.9 | 2467.2 | 6.50 ± 0.10 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
+ Coverage 81.45% 81.54% +0.09%
==========================================
Files 105 107 +2
Lines 25862 25945 +83
==========================================
+ Hits 21065 21156 +91
+ Misses 4797 4789 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JulianGCalderon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits, but looks good!
Co-authored-by: Julian Gonzalez Calderon <[email protected]>
|
✅ Code is now correctly formatted. |
gabrielbosio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that changing the GasReserve tests to property tests increased execution time of the test job to ~100% (i.e. +20 min approx.) so we can revert that change in this context
Implement GasReserve libfuncs
Implements the GasReserve libfuncs:
Closes #1426
Introduces Breaking Changes?
Yes/No.
starknet-blocks.ymlworkflow to use these PRs.These PRs should be merged after this one right away, in that order.
Checklist