Implement QM31 libfuncs

Cargo.toml

@@ -52,7 +52,7 @@ criterion = "0.5.1"
 itertools = "0.14.0"
 k256 = "0.13.4"
 keccak = "0.1.5"
-lambdaworks-math = "0.11.0"
+lambdaworks-math = "0.13.0"
 lazy_static = "1.5"
 libc = "0.2"
 libloading = "0.8.6"
@@ -78,7 +78,7 @@ sierra-emu = { path = "debug_utils/sierra-emu", version = "0.7.1" }
 smallvec = "1.13.2"
 starknet-crypto = "0.8.1"
 starknet-curve = "0.6.0"
-starknet-types-core = "0.2.0"
+starknet-types-core = { version = "0.2.4", features = ["hash"]}
 stats_alloc = "0.1.10"
 tempfile = "3.15.0"
 test-case = "3.3"
@@ -168,6 +168,7 @@ sha2.workspace = true
 # Runtime library dependencies.
 rand.workspace = true
 starknet-curve.workspace = true
+lambdaworks-math.workspace = true
 
 [dev-dependencies]
 cairo-lang-compiler.workspace = true

binaries/cairo-native-bin-utils/src/lib.rs

@@ -166,6 +166,12 @@ fn jitvalue_to_felt(value: &Value) -> Vec<Felt> {
         Value::EcState(a, b, c, d) => {
             vec![*a, *b, *c, *d]
         }
+        Value::QM31(a, b, c, d) => vec![
+            Felt::from(*a),
+            Felt::from(*b),
+            Felt::from(*c),
+            Felt::from(*d),
+        ],
         Value::Secp256K1Point(Secp256k1Point {
             x,
             y,

corelib.patch

@@ -1044,20 +1044,3 @@ diff --color=auto -crN cairo2/corelib/src/test.cairo cairo2/corelib_1/src/test.c
   mod hash_test;
   mod integer_test;
   mod iter_test;
-***************
-*** 24,30 ****
-  mod option_test;
-  mod plugins_test;
-  mod print_test;
-! mod qm31_test;
-  mod range_test;
-  mod result_test;
-  mod secp256k1_test;
---- 24,30 ----
-  mod option_test;
-  mod plugins_test;
-  mod print_test;
-! // mod qm31_test;
-  mod range_test;
-  mod result_test;
-  mod secp256k1_test;

src/arch.rs

@@ -146,6 +146,12 @@ impl AbiArgument for ValueWithInfoWrapper<'_> {
                 x0.to_bytes(buffer, find_dict_drop_override)?;
                 y0.to_bytes(buffer, find_dict_drop_override)?;
             }
+            (Value::QM31(a, b, c, d), CoreTypeConcrete::QM31(_)) => {
+                a.to_bytes(buffer, find_dict_drop_override)?;
+                b.to_bytes(buffer, find_dict_drop_override)?;
+                c.to_bytes(buffer, find_dict_drop_override)?;
+                d.to_bytes(buffer, find_dict_drop_override)?;
+            }
             (Value::Enum { tag, value, .. }, CoreTypeConcrete::Enum(info)) => {
                 if self.info.is_memory_allocated(self.registry)? {
                     let abi_ptr = self.value.to_ptr(

src/executor.rs

@@ -433,6 +433,24 @@ fn parse_result(
             registry,
             true,
         )?),
+        CoreTypeConcrete::QM31(_) => match return_ptr {
+            Some(ptr) => Ok(Value::from_ptr(ptr, type_id, registry, true)?),
+            None => {
+                #[cfg(target_arch = "x86_64")]
+                // Since x86_64's return values hold at most two different 64bit registers,
+                // everything bigger than u128 will be returned by memory, therefore making
+                // this branch is unreachable on that architecture.
+                return Err(Error::ParseAttributeError);
+
+                #[cfg(target_arch = "aarch64")]
+                Ok(Value::QM31(
+                    u32::try_from(ret_registers[0])?,
+                    u32::try_from(ret_registers[1])?,
+                    u32::try_from(ret_registers[2])?,
+                    u32::try_from(ret_registers[3])?,
+                ))
+            }
+        },
         CoreTypeConcrete::Felt252(_)
         | CoreTypeConcrete::Starknet(
             StarknetTypeConcrete::ClassHash(_)
@@ -675,7 +693,6 @@ fn parse_result(
         // 2.11.1
         CoreTypeConcrete::Blake(_) => native_panic!("blake not yet implemented as results"),
         // 2.12.0
-        CoreTypeConcrete::QM31(_) => native_panic!("qm31 not yet implemented as results"),
         CoreTypeConcrete::GasReserve(_) => {
             native_panic!("gas reserve not yet implemented as results")
         }

src/libfuncs.rs

@@ -69,6 +69,7 @@ mod mem;
 mod nullable;
 mod pedersen;
 mod poseidon;
+mod qm31;
 mod starknet;
 mod r#struct;
 mod uint256;
@@ -255,7 +256,9 @@ impl LibfuncBuilder for CoreConcreteLibfunc {
                 metadata,
                 &info.signature.param_signatures,
             ),
-            Self::QM31(_) => native_panic!("Implement QM31 libfunc"),
+            Self::QM31(selector) => self::qm31::build(
+                context, registry, entry, location, helper, metadata, selector,
+            ),
             Self::UnsafePanic(_) => native_panic!("Implement unsafe_panic libfunc"),
             Self::GasReserve(_) => native_panic!("Implement gas_reserve libfunc"),
             Self::DummyFunctionCall(_) => native_panic!("Implement dummy_function_call libfunc"),