Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rust to 1.84.0 #1039

Merged
merged 1 commit into from
Jan 10, 2025
Merged

update rust to 1.84.0 #1039

merged 1 commit into from
Jan 10, 2025

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jan 10, 2025

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.959 ± 0.030 3.919 3.999 1.00
base dict_insert.cairo (AOT) 4.152 ± 0.044 4.068 4.217 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_insert.cairo (JIT) 3.908 ± 0.031 3.854 3.954 1.00
head dict_insert.cairo (AOT) 4.076 ± 0.026 4.030 4.119 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 4.084 ± 0.032 4.039 4.140 1.00
base dict_snapshot.cairo (AOT) 4.233 ± 0.029 4.180 4.276 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_snapshot.cairo (JIT) 4.091 ± 0.038 4.038 4.183 1.00
head dict_snapshot.cairo (AOT) 4.218 ± 0.020 4.185 4.252 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.102 ± 0.027 4.065 4.138 1.00
base factorial_2M.cairo (AOT) 4.321 ± 0.046 4.254 4.404 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 4.136 ± 0.024 4.095 4.181 1.00
head factorial_2M.cairo (AOT) 4.316 ± 0.027 4.280 4.355 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.626 ± 0.017 3.601 3.659 1.00
base fib_2M.cairo (AOT) 3.861 ± 0.034 3.813 3.924 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.676 ± 0.020 3.639 3.694 1.00
head fib_2M.cairo (AOT) 3.861 ± 0.023 3.810 3.894 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.854 ± 0.042 3.788 3.904 1.00
base linear_search.cairo (AOT) 4.081 ± 0.052 3.977 4.173 1.06 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 3.842 ± 0.026 3.811 3.904 1.00
head linear_search.cairo (AOT) 3.953 ± 0.029 3.911 4.014 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.966 ± 0.041 3.904 4.023 1.00
base logistic_map.cairo (AOT) 4.052 ± 0.075 3.961 4.227 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.948 ± 0.029 3.923 4.019 1.00
head logistic_map.cairo (AOT) 4.035 ± 0.028 3.995 4.080 1.02 ± 0.01

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (f1e895f) to head (4c9cc24).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   80.88%   80.89%   +0.01%     
==========================================
  Files         107      107              
  Lines       29470    29445      -25     
==========================================
- Hits        23836    23819      -17     
+ Misses       5634     5626       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 22.571 ± 0.139 22.309 22.739 92.25 ± 5.33
cairo-native (embedded AOT) 4.430 ± 0.047 4.356 4.505 18.10 ± 1.06
cairo-native (embedded JIT using LLVM's ORC Engine) 4.212 ± 0.057 4.128 4.332 17.22 ± 1.02
cairo-native (standalone AOT with -march=native) 0.245 ± 0.014 0.225 0.279 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 6.132 ± 0.099 6.025 6.312 18.99 ± 0.44
cairo-native (embedded AOT) 4.527 ± 0.090 4.371 4.660 14.02 ± 0.36
cairo-native (embedded JIT using LLVM's ORC Engine) 4.403 ± 0.062 4.301 4.494 13.64 ± 0.29
cairo-native (standalone AOT with -march=native) 0.323 ± 0.005 0.315 0.329 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 15.430 ± 0.127 15.187 15.616 11.37 ± 0.09
cairo-native (embedded AOT) 4.422 ± 0.030 4.389 4.493 3.26 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 4.187 ± 0.034 4.140 4.247 3.09 ± 0.03
cairo-native (standalone AOT with -march=native) 1.357 ± 0.001 1.355 1.359 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 15.352 ± 0.146 15.139 15.694 191.46 ± 1.94
cairo-native (embedded AOT) 3.935 ± 0.037 3.882 4.012 49.07 ± 0.49
cairo-native (embedded JIT using LLVM's ORC Engine) 3.703 ± 0.021 3.672 3.733 46.18 ± 0.30
cairo-native (standalone AOT with -march=native) 0.080 ± 0.000 0.080 0.081 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.985 ± 0.068 5.887 6.116 2780.38 ± 182.58
cairo-native (embedded AOT) 4.161 ± 0.085 4.047 4.369 1933.18 ± 131.07
cairo-native (embedded JIT using LLVM's ORC Engine) 4.060 ± 0.053 3.993 4.148 1886.34 ± 124.42
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.003 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.940 ± 0.050 5.876 6.061 24.50 ± 0.21
cairo-native (embedded AOT) 4.194 ± 0.058 4.104 4.311 17.30 ± 0.24
cairo-native (embedded JIT using LLVM's ORC Engine) 4.150 ± 0.057 4.084 4.269 17.12 ± 0.24
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.242 0.243 1.00

@edg-l edg-l enabled auto-merge January 10, 2025 14:11
@edg-l edg-l disabled auto-merge January 10, 2025 14:11
@gabrielbosio gabrielbosio added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 45a4eaa Jan 10, 2025
32 checks passed
@gabrielbosio gabrielbosio deleted the upd_rust84 branch January 10, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants