Skip to content

feat: Implement hints on field_arithmetic lib #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmoletta merged 105 commits into from
Apr 20, 2023
Merged

feat: Implement hints on field_arithmetic lib #985

Changes from 1 commit
Commits
Show all changes
105 commits
Select commit Hold shift + click to select a range
ada5a2b
Add hint code for UINT348_UNSIGNED_DIV_REM
fmoletta Apr 11, 2023
d1b7e84
Add file for uint348 files
fmoletta Apr 11, 2023
c409d01
Add pack & split for uint348
fmoletta Apr 12, 2023
93c6f4e
Move comment
fmoletta Apr 12, 2023
82dbf2b
Implement uint348_unsigned_div_rem hint
fmoletta Apr 12, 2023
df9deb2
Add integration test
fmoletta Apr 12, 2023
7b2f5d9
Add integration test
fmoletta Apr 12, 2023
b1a3fbb
Add unit tests
fmoletta Apr 12, 2023
110605a
Add hint on split_128
fmoletta Apr 12, 2023
8cc3ce7
Test split_128 hint
fmoletta Apr 12, 2023
378788d
Add add_no_uint384_hint
fmoletta Apr 12, 2023
271a38c
Fix hint + add tests
fmoletta Apr 12, 2023
ed7de28
Add hint code for UINT348_UNSIGNED_DIV_REM_EXPAND
fmoletta Apr 12, 2023
be408c3
Msc fixes
fmoletta Apr 12, 2023
8c6fb8c
Add integration test
fmoletta Apr 12, 2023
512a80e
Reduce Uint384_expand representation to the 3 used limbs
fmoletta Apr 12, 2023
089398e
Add unit test
fmoletta Apr 12, 2023
6852a87
Add hint code for UINT384_SQRT
fmoletta Apr 13, 2023
e3e05be
Add implementation for hint on sqrt
fmoletta Apr 13, 2023
faf4765
Integration test
fmoletta Apr 13, 2023
d30d404
Add unit tests
fmoletta Apr 13, 2023
aa9ce34
Merge branch 'main' of github.com:lambdaclass/cairo-rs into uint348-h…
fmoletta Apr 13, 2023
f257b56
Fix missing directive
fmoletta Apr 13, 2023
4218e80
Run cairo-format
fmoletta Apr 13, 2023
e1d0100
Add changelog entry
fmoletta Apr 13, 2023
51c7dc3
Spelling
fmoletta Apr 13, 2023
f340a3a
Add hint code + Uint768 type
fmoletta Apr 13, 2023
08ebafb
Implement hint unsigned_div_rem_uint768_by_uint384
fmoletta Apr 13, 2023
3f8bdfb
Update src/hint_processor/builtin_hint_processor/uint384.rs
fmoletta Apr 13, 2023
43f3977
Update src/hint_processor/builtin_hint_processor/uint384.rs
fmoletta Apr 13, 2023
0045914
Update src/hint_processor/builtin_hint_processor/uint384.rs
fmoletta Apr 13, 2023
4f89202
Make hint code more readable
fmoletta Apr 13, 2023
c4b7f6e
Add integration test
fmoletta Apr 13, 2023
f0400b9
Add test
fmoletta Apr 13, 2023
a0368e2
Add unit test
fmoletta Apr 13, 2023
ce01868
Add changelog entry + fmt
fmoletta Apr 13, 2023
bd3214a
Fix plural
fmoletta Apr 13, 2023
f6359ad
Merge branch 'uint348-hints' into uint384-hints-extended
fmoletta Apr 13, 2023
96bc852
cargo fmt
fmoletta Apr 13, 2023
bf5a22c
Add first draft of get_square_root
fmoletta Apr 13, 2023
1ada5b3
Fix test
fmoletta Apr 14, 2023
764e28a
Fix syntax
fmoletta Apr 14, 2023
b259bd0
Fix test
fmoletta Apr 14, 2023
ffe9508
Add necessary lib fns
fmoletta Apr 14, 2023
24e06fe
Merge branch 'main' into uint348-hints
fmoletta Apr 14, 2023
6861479
fix fmt
fmoletta Apr 14, 2023
4f094b4
Fix test value
fmoletta Apr 14, 2023
4059972
Merge branch 'uint348-hints' into uint384-hints-extended
fmoletta Apr 14, 2023
ec67ecb
Merge branch 'uint384-hints-extended' into field-arithmetic-hints
fmoletta Apr 14, 2023
18011e0
Add test program
fmoletta Apr 14, 2023
afe1cca
Add hint to execute_hint
fmoletta Apr 14, 2023
355b836
Fix wrong hint being tested
fmoletta Apr 14, 2023
9c159ef
Implement sqrt
fmoletta Apr 14, 2023
9c5db20
Add test fix file
fmoletta Apr 14, 2023
e9982da
Fix _sqrt_mod_tonelli_shanks implementation
fmoletta Apr 17, 2023
c3be7b3
Expand integration test
fmoletta Apr 17, 2023
376cd3d
Add unit test
fmoletta Apr 17, 2023
6906494
Add proptests
fmoletta Apr 17, 2023
40ad285
Merge branch 'main' of github.com:lambdaclass/cairo-rs into uint384-h…
fmoletta Apr 17, 2023
fee4a04
Fix merge conflict
fmoletta Apr 17, 2023
3284a6d
Fix merge conflict
fmoletta Apr 17, 2023
0032e0a
Merge branch 'uint384-hints-extended' into field-arithmetic-hints
fmoletta Apr 17, 2023
b61d958
Add changelog entry
fmoletta Apr 17, 2023
fc9573f
Use no-std compatible rng when std is not enabled
fmoletta Apr 17, 2023
ed1c58c
Clippy
fmoletta Apr 17, 2023
c469789
Add misc tests
fmoletta Apr 17, 2023
d744a6f
Remove vec use
fmoletta Apr 17, 2023
3f79a21
Remove merge conflict from changelog
fmoletta Apr 17, 2023
37bdc30
Use seeded rng instead of from_entropy
fmoletta Apr 17, 2023
03eb74c
Catch potential zero divison errors
fmoletta Apr 17, 2023
63032a4
Catch potential zero divison errors
fmoletta Apr 17, 2023
585fdeb
Merge branch 'main' of github.com:lambdaclass/cairo-rs into uint384-h…
fmoletta Apr 17, 2023
8836c52
Prevent zero divison error in is_quad_residue fn
fmoletta Apr 17, 2023
1964998
Add tests case when no successes
fmoletta Apr 17, 2023
798cd34
Add tests case when success_gx
fmoletta Apr 17, 2023
886f648
Add some tests
fmoletta Apr 17, 2023
389d39a
Merge branch 'uint384-hints-extended' into field-arithmetic-hints
fmoletta Apr 17, 2023
117a5c8
Fix test value
fmoletta Apr 17, 2023
786bdd7
Fix test value
fmoletta Apr 18, 2023
11014ff
Add unit test for specific case
fmoletta Apr 18, 2023
367a4f7
Add specific case unit test
fmoletta Apr 18, 2023
803b700
Catch prime being 0
fmoletta Apr 18, 2023
3341550
Add prime check to sqrt_prime_power + Fix proptest values + unify rng…
fmoletta Apr 18, 2023
43ee65c
Use `trailing_zeros` instead of sympy trailing implementation
fmoletta Apr 18, 2023
2afda64
Fix proptest format
fmoletta Apr 18, 2023
826484c
Remove unused feature from tml
fmoletta Apr 18, 2023
fa6b0da
Merge branch 'main' of github.com:lambdaclass/cairo-rs into field-ari…
fmoletta Apr 19, 2023
168a059
Clean test file
fmoletta Apr 19, 2023
d5717d0
Fix merge conflict
fmoletta Apr 19, 2023
dff6f06
Fix bug in add_no_uint384_check
fmoletta Apr 19, 2023
36b4e62
Add benchmark file
fmoletta Apr 19, 2023
65e515f
Merge branch 'main' into field-arithmetic-hints
fmoletta Apr 19, 2023
b022b88
Remove duplicated file
fmoletta Apr 19, 2023
4e75245
Merge branch 'field-arithmetic-hints' of github.com:lambdaclass/cairo…
fmoletta Apr 19, 2023
b5f7e77
Fix cairo file
fmoletta Apr 19, 2023
8856f0b
Fix wasm tests
fmoletta Apr 19, 2023
017e8d0
Move proptest to dev-dependencies
fmoletta Apr 19, 2023
c955075
Revert "Move proptest to dev-dependencies"
fmoletta Apr 20, 2023
35b2724
Revert change + use feature directive for proptest import
fmoletta Apr 20, 2023
607eee3
Merge branch 'main' of github.com:lambdaclass/cairo-rs into field-ari…
fmoletta Apr 20, 2023
9ffb530
fmt
fmoletta Apr 20, 2023
e5e7915
Merge branch 'main' into field-arithmetic-hints
fmoletta Apr 20, 2023
d75c541
Update src/hint_processor/builtin_hint_processor/field_arithmetic.rs
fmoletta Apr 20, 2023
df2c60f
Remove unused import
fmoletta Apr 20, 2023
4bd40cf
Merge branch 'main' of github.com:lambdaclass/cairo-rs into field-ari…
fmoletta Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ felt = { package = "cairo-felt", path = "./felt", version = "0.3.0-rc1", default
] }
bitvec = { version = "1", default-features = false, features = ["alloc"] }

[dev-dependencies]
proptest = "1.0.0"

[target.'cfg(target_arch = "wasm32")'.dev-dependencies]
wasm-bindgen-test = "0.3.34"
assert_matches = "1.5.0"
Expand All @@ -89,7 +92,6 @@ iai = "0.1"
rusty-hook = "0.11"
assert_matches = "1.5.0"
criterion = { version = "0.3", features = ["html_reports"] }
proptest = "1.0.0"

[[bench]]
path = "bench/iai_benchmark.rs"
Expand Down