Skip to content

Conversation

@Oppen
Copy link
Contributor

@Oppen Oppen commented Apr 12, 2023

Adds a new field to the checklist to remind us of updating the CHANGELOG on relevant PRs.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@igaray
Copy link
Collaborator

igaray commented Apr 12, 2023

I had the same in #959

@Oppen
Copy link
Contributor Author

Oppen commented Apr 12, 2023

I had the same in #959

Yes, but that includes other changes that are still waiting for feedback.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #961 (d763071) into main (5fab4cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files          74       74           
  Lines       30392    30392           
=======================================
  Hits        29708    29708           
  Misses        684      684           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen added this pull request to the merge queue Apr 12, 2023
Merged via the queue into main with commit 2ee5e0c Apr 12, 2023
@Oppen Oppen deleted the changelog_tick branch April 12, 2023 14:58
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants