-
Notifications
You must be signed in to change notification settings - Fork 212
Initial release process document #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Release Process | ||
| - [ ] Pull latest from `main` branch. | ||
| `git checkout main && git pull origin main` | ||
| - [ ] Determine release version string dependending on whether changes included | ||
| in changelog are API breaking, it's a release candidate, etc. | ||
| The release string should have the format "vX.Y.Z", with a possible | ||
| trailing "-rcN" and follow [semantic versioning](https://semver.org/). | ||
| - [ ] Checkout branch named `release-N` where N is the version string. | ||
| `git checkout -b release-N` | ||
| - [ ] Update the version field in the package entry of `Cargo.toml` files. | ||
| - The versions must be the same. | ||
| - There are 4 relevant `Cargo.toml` files in the repo: | ||
| - `Cargo.toml`: update the version string. | ||
| - `cairo-vm-cli/Cargo.toml`: update the version string and also the `cairo-vm` dependency version to match the above. | ||
| - `felt/Cargo.toml`: update the version string. | ||
| - `deps/parse-hyperlinks/Cargo.toml`: this vendored dependency needs its version bumped, but does not need to match the other crate versions. | ||
igaray marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - [Here](https://github.com/lambdaclass/cairo-rs/pull/948/files) is an example pull request with these changes. | ||
| - [ ] Run `cargo update` and `git add Cargo.lock` | ||
| - [ ] Update `CHANGELOG.md`: | ||
| - Verify that the changelog is up to date. | ||
| - Add a title with the release version string just below the `Upcoming Changes` section. | ||
| - [ ] Commit your changes, push your branch, and create a pull request. | ||
| - [ ] Merge after CI and review passes. | ||
| - [ ] Pull latest from `main` again. | ||
| - [ ] Tag commit with version string and push tag. | ||
igaray marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| `git tag -a <version string> -m "Release..."` | ||
| - [ ] Watch the `publish` workflow run in Github Actions. | ||
igaray marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - [ ] Verify all the crates are available on crates.io with the correct versions. | ||
| - [cairo-vm](https://crates.io/crates/cairo-vm) | ||
| - [cairo-felt](https://crates.io/crates/cairo-felt) | ||
| - [cairo-take-until-unbalanced](https://crates.io/crates/cairo-take_until_unbalanced) | ||
| - [ ] Create a release in Github. | ||
| - Select the recently created tag. | ||
| - Set the title to the version string. | ||
| - If it is a release candidate, mark it as a draft release. | ||
| - [ ] Announce release through corresponding channels. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.