Check capacity of vector before resizing #805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jrigada
requested review from
HermanObst,
Juan-M-V,
Oppen,
entropidelic,
fmoletta,
igaray,
juanbono and
pefontana
as code owners
Oppen
reviewed
Feb 1, 2023
| //Forgoing this check would allow data to be inserted in a different index | ||
|
|
||
| if segment.len() <= value_offset { | ||
| if (segment.capacity() + value_offset + 1) * mem::size_of::<MaybeRelocatable>() |
Contributor
There was a problem hiding this comment.
This will overflow if the condition is true. I'm personally not sure it's valuable to catch this case, and certainly I don't think this is the proper place to fix it. Instead, we should make sure offsets in relocatables don't exceed 47 bits, which is how big they're specified to be.
Contributor
There was a problem hiding this comment.
I'll fix this by using try_reserve in a different PR. It should be cleaner and more robust, while also avoiding other possible points of failure (it might still fail to allocate and panic as it's implemented).
I'll refer to this PR and close it when ready.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check capacity of vector before resizing
Description
PR to solve the issue reported by Patrick from Fuzzing Labs
#798
Description of the pull request changes and motivation.
Checklist