Skip to content

Conversation

@gabrielbosio
Copy link
Collaborator

No description provided.

@gabrielbosio gabrielbosio marked this pull request as ready for review November 14, 2025 21:14
@gabrielbosio gabrielbosio marked this pull request as draft November 14, 2025 21:14
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     22.782 s ±  0.051 s    [User: 21.901 s, System: 0.880 s]
  Range (min … max):   22.746 s … 22.819 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     22.583 s ±  0.011 s    [User: 21.689 s, System: 0.891 s]
  Range (min … max):   22.575 s … 22.590 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     12.269 s ±  0.005 s    [User: 22.060 s, System: 0.912 s]
  Range (min … max):   12.265 s … 12.273 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     12.343 s ±  0.308 s    [User: 22.010 s, System: 0.908 s]
  Range (min … max):   12.125 s … 12.561 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.01 ± 0.03 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):      9.558 s ±  0.314 s    [User: 34.141 s, System: 1.103 s]
  Range (min … max):    9.335 s …  9.780 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):      9.548 s ±  0.382 s    [User: 34.901 s, System: 1.125 s]
  Range (min … max):    9.278 s …  9.818 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.00 ± 0.05 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.684 s ±  0.074 s    [User: 34.207 s, System: 1.100 s]
  Range (min … max):    9.632 s …  9.736 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.628 s ±  0.142 s    [User: 34.377 s, System: 1.064 s]
  Range (min … max):    9.527 s …  9.728 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.227 s ±  0.093 s    [User: 34.810 s, System: 1.160 s]
  Range (min … max):    9.161 s …  9.292 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.339 s ±  0.041 s    [User: 35.108 s, System: 1.112 s]
  Range (min … max):    9.310 s …  9.368 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):      9.446 s ±  0.109 s    [User: 34.875 s, System: 1.228 s]
  Range (min … max):    9.369 s …  9.523 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.707 s ±  0.053 s    [User: 35.089 s, System: 1.203 s]
  Range (min … max):    9.669 s …  9.744 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.03 ± 0.01 times faster than hyper_threading_pr threads: 16


Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielbosio gabrielbosio marked this pull request as ready for review November 14, 2025 21:24
@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 1.962 ± 0.017 1.938 1.994 1.01 ± 0.01
head big_factorial 1.950 ± 0.015 1.924 1.972 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 1.885 ± 0.009 1.872 1.900 1.00
head big_fibonacci 1.885 ± 0.012 1.862 1.899 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 6.764 ± 0.133 6.605 7.021 1.00
head blake2s_integration_benchmark 6.788 ± 0.155 6.627 7.044 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.043 ± 0.023 2.006 2.074 1.01 ± 0.01
head compare_arrays_200000 2.028 ± 0.010 2.019 2.049 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.363 ± 0.009 1.348 1.379 1.01 ± 0.01
head dict_integration_benchmark 1.356 ± 0.009 1.342 1.369 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.135 ± 0.006 1.127 1.146 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.133 ± 0.013 1.121 1.158 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 6.851 ± 0.080 6.741 6.951 1.00 ± 0.02
head integration_builtins 6.850 ± 0.080 6.751 6.960 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 6.891 ± 0.094 6.768 7.019 1.01 ± 0.02
head keccak_integration_benchmark 6.819 ± 0.073 6.744 6.957 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 1.990 ± 0.008 1.981 2.006 1.00
head linear_search 1.995 ± 0.021 1.974 2.048 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.430 ± 0.008 1.423 1.450 1.00
head math_cmp_and_pow_integration_benchmark 1.441 ± 0.009 1.427 1.460 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.392 ± 0.006 1.379 1.399 1.00 ± 0.01
head math_integration_benchmark 1.391 ± 0.008 1.378 1.406 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.141 ± 0.003 1.135 1.147 1.00 ± 0.01
head memory_integration_benchmark 1.135 ± 0.005 1.129 1.143 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.458 ± 0.003 1.452 1.463 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.456 ± 0.014 1.442 1.492 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 507.4 ± 2.7 504.5 513.0 1.00
head pedersen 508.1 ± 9.7 503.1 535.1 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 590.0 ± 3.3 584.2 593.4 1.01 ± 0.01
head poseidon_integration_benchmark 586.5 ± 2.8 583.4 591.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.717 ± 0.011 1.704 1.740 1.00
head secp_integration_benchmark 1.719 ± 0.011 1.704 1.741 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 658.6 ± 2.3 655.5 663.3 1.00 ± 0.01
head set_integration_benchmark 657.8 ± 3.8 654.5 667.6 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.868 ± 0.041 3.827 3.940 1.00 ± 0.02
head uint256_integration_benchmark 3.855 ± 0.041 3.809 3.916 1.00

@gabrielbosio gabrielbosio added this pull request to the merge queue Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.97%. Comparing base (581c437) to head (4e73c59).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2267   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files         104      104           
  Lines       36783    36783           
=======================================
  Hits        35304    35304           
  Misses       1479     1479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit 746d491 Nov 14, 2025
95 checks passed
@gabrielbosio gabrielbosio deleted the prepare_3.0.0-rc.5 branch November 14, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants